<div dir="ltr">Hi,<div><br></div><div>Another nudge for some feedback on this patch series.</div><div><br></div><div>Regards,</div><div>Naush</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 4 Mar 2021 at 08:17, Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
This version (v4) of the patch series adds two further commits to v3.<br>
<br>
Patches 1 to 5 are identical to v3, except that I have added a line to the commit<br>
messages saying the change would break the unit tests because of a change in the<br>
logic of the helper.<br>
<br>
Patch 6 updates the unit tests with the correct behavior. Unfortunately, my<br>
attempts to get vimc working on my platform did not end well, so I made a local<br>
mod to run the tests with a physical camera device. All tests do pass, but I<br>
would appreciate if somebody else could run this again with the vimc device to<br>
verify everything is passing.<br>
<br>
Patch 7 simply fixes a typo in the unit test filename.<br>
<br>
Thanks,<br>
Naush<br>
<br>
Naushir Patuck (7):<br>
libcamera: delayed_controls: Add notion of priority write<br>
utils: raspberrypi: Add a DelayedControls log parser<br>
libcamera: delayed_controls: Remove unneeded write when starting up<br>
libcamera: delayed_controls: Remove spurious no-op queued controls<br>
libcamera: delayed_controls: Fix off-by-one error in get()<br>
test: delayed_controls: Fixup tests after recent DelayedControls<br>
changes<br>
test: delayed_controls: Rename delayed_contols.cpp to<br>
delayed_controls.cpp<br>
<br>
include/libcamera/internal/delayed_controls.h | 13 +-<br>
src/libcamera/delayed_controls.cpp | 74 ++++++++----<br>
src/libcamera/pipeline/ipu3/ipu3.cpp | 8 +-<br>
.../pipeline/raspberrypi/raspberrypi.cpp | 13 +-<br>
src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +-<br>
...layed_contols.cpp => delayed_controls.cpp} | 51 +++++---<br>
test/meson.build | 2 +-<br>
utils/raspberrypi/delayedctrls_parse.py | 111 ++++++++++++++++++<br>
8 files changed, 219 insertions(+), 61 deletions(-)<br>
rename test/{delayed_contols.cpp => delayed_controls.cpp} (84%)<br>
create mode 100644 utils/raspberrypi/delayedctrls_parse.py<br>
<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div>