<div dir="ltr"><div dir="ltr">Hi Sebastian,<div><br></div><div>Thank you for your patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 28 Mar 2021 at 15:27, Sebastian Fricke <<a href="mailto:sebastian.fricke@posteo.net">sebastian.fricke@posteo.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The comment states, that we get the device format to pass it to the IPA,<br>
but the variable `sensorFormat` is not used again after it's assignment.<br>
Remove it, together with the comment.<br>
<br>
Signed-off-by: Sebastian Fricke <<a href="mailto:sebastian.fricke@posteo.net" target="_blank">sebastian.fricke@posteo.net</a>><br></blockquote><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
Tested on Raspberry Pi 4 with IMX219 without issues.<br>
---<br>
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ---<br>
 1 file changed, 3 deletions(-)<br>
<br>
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
index 378a5227..f22e286e 100644<br>
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
@@ -1238,9 +1238,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)<br>
        std::map<unsigned int, ControlInfoMap> entityControls;<br>
        ipa::RPi::IPAConfig ipaConfig;<br>
<br>
-       /* Get the device format to pass to the IPA. */<br>
-       V4L2DeviceFormat sensorFormat;<br>
-       unicam_[Unicam::Image].dev()->getFormat(&sensorFormat);<br>
        /* Inform IPA of stream configuration and sensor controls. */<br>
        unsigned int i = 0;<br>
        for (auto const &stream : isp_) {<br>
-- <br>
2.25.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>