<div dir="ltr"><div dir="ltr">Hi Sebastian,<div><br></div><div>Thank you for your patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 28 Mar 2021 at 18:03, Sebastian Fricke <<a href="mailto:sebastian.fricke@posteo.net" target="_blank">sebastian.fricke@posteo.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">s/Return the validated limits out though metadata./<br>
  Return the validated limits via metadata./<br>
<br>
Signed-off-by: Sebastian Fricke <<a href="mailto:sebastian.fricke@posteo.net" target="_blank">sebastian.fricke@posteo.net</a>><br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---<br>
It is probably debatable, if we should remove that comment completely,<br>
as the code is quite self explanatory. But it might help.<br>
---<br></blockquote><div><br></div><div><div>I see no harm in keeping the comment.</div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>></div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 src/ipa/raspberrypi/raspberrypi.cpp | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp<br>
index ed2d9a54..dad6395f 100644<br>
--- a/src/ipa/raspberrypi/raspberrypi.cpp<br>
+++ b/src/ipa/raspberrypi/raspberrypi.cpp<br>
@@ -1066,7 +1066,7 @@ void IPARPi::applyFrameDurations(double minFrameDuration, double maxFrameDuratio<br>
                                       minSensorFrameDuration, maxSensorFrameDuration);<br>
        maxFrameDuration_ = std::max(maxFrameDuration_, minFrameDuration_);<br>
<br>
-       /* Return the validated limits out though metadata. */<br>
+       /* Return the validated limits via metadata. */<br>
        libcameraMetadata_.set(controls::FrameDurations,<br>
                               { static_cast<int64_t>(minFrameDuration_),<br>
                                 static_cast<int64_t>(maxFrameDuration_) });<br>
-- <br>
2.25.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>