<div dir="ltr"><div dir="ltr">Hi Sebastian,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 30 Mar 2021 at 11:33, Sebastian Fricke <<a href="mailto:sebastian.fricke@posteo.net" target="_blank">sebastian.fricke@posteo.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hey Naushir,<br>
<br>
Thank you for the patch.<br>
Just out of curiosity so this assert makes sure that bayerRequeueCount<br>
was not increased more than once during each loop cycle right? Because<br>
otherwise this assert just checks the same condition that the if clause<br>
above checks, right? Because every increase of the variable comes with a<br>
pop from the queue.<br></blockquote><div><br></div><div>Conceptually, there are 2 queues, one for the buffers available to use. and</div><div>another for the buffers that have been filled up by the device.  The assert here</div><div>is to ensure commonality between the two when all of the buffers have been</div><div>recycled back to the device.  Hope that make sense :)</div><div><br></div><div>Regards,</div><div>Naush</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
On 30.03.2021 08:56, Naushir Patuck wrote:<br>
>s/embedded/bayer/<br>
><br>
>Signed-off-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
Reviewed-by: Sebastian Fricke <<a href="mailto:sebastian.fricke@posteo.net" target="_blank">sebastian.fricke@posteo.net</a>><br>
<br>
>---<br>
> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
>diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
>index f22e286ed87a..2a917455500f 100644<br>
>--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
>+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
>@@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em<br>
>                        * pending embedded data buffers.<br>
>                        */<br>
>                       if (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {<br>
>-                              /* The embedded queue must be empty at this point! */<br>
>+                              /* The bayer queue must be empty at this point! */<br>
>                               ASSERT(bayerQueue_.empty());<br>
><br>
>                               LOG(RPI, Warning) << "Flushing embedded data stream!";<br>
>-- <br>
>2.25.1<br>
><br>
>_______________________________________________<br>
>libcamera-devel mailing list<br>
><a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
><a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div>
</div>