<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for your patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 24 Mar 2021 at 11:44, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This allows derived classes to override them if they have any special<br>
behaviours to implement. For instance if a particular camera mode<br>
produces a different signal level to other modes, you might choose to<br>
address that in the gain or exposure methods.<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
src/ipa/raspberrypi/cam_helper.hpp | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp<br>
index 1b2d6eec..4053a870 100644<br>
--- a/src/ipa/raspberrypi/cam_helper.hpp<br>
+++ b/src/ipa/raspberrypi/cam_helper.hpp<br>
@@ -66,8 +66,8 @@ public:<br>
virtual ~CamHelper();<br>
void SetCameraMode(const CameraMode &mode);<br>
MdParser &Parser() const { return *parser_; }<br>
- uint32_t ExposureLines(double exposure_us) const;<br>
- double Exposure(uint32_t exposure_lines) const; // in us<br>
+ virtual uint32_t ExposureLines(double exposure_us) const;<br>
+ virtual double Exposure(uint32_t exposure_lines) const; // in us<br>
virtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,<br>
double maxFrameDuration) const;<br>
virtual uint32_t GainCode(double gain) const = 0;<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>