<div dir="ltr">Hi Umang, thanks for the patch.<br><br>On Thu, Apr 29, 2021 at 8:26 PM Niklas Söderlund <<a href="mailto:niklas.soderlund@ragnatech.se">niklas.soderlund@ragnatech.se</a>> wrote:<br>><br>> Hi Umang,<br>><br>> Thanks for your work.<br>><br>> On 2021-04-29 16:27:41 +0530, Umang Jain wrote:<br>> > libcamera internal headers are not installed system-wide. Hence, any<br>> > inclusion of internal headers should be follow the #include directive<br>> > form:<br>> >       #include "libcamera/internal/header.h"<br>><br>> This also needs fixing in generic_camera_buffer.cpp and<br>> post_processor.h.<br>><br><br>My quick grep shows the following result. Would you fix them as well?<br><br><blockquote style="margin:0 0 0 40px;border:none;padding:0px">$ rg "#include <libcamera/internal"<br>test/bayer-format.cpp<br>10:#include <libcamera/internal/bayer_format.h><br>src/android/post_processor.h<br>13:#include <libcamera/internal/buffer.h><br>src/android/camera_stream.h<br>22:#include <libcamera/internal/buffer.h><br>src/android/mm/generic_camera_buffer.cpp<br>10:#include <libcamera/internal/buffer.h></blockquote><div><br></div>-Hiro<div><br>> ><br>> > This was not the case with buffer.h internal header. Fix it.<br>> ><br>> > Signed-off-by: Umang Jain <<a href="mailto:umang.jain@ideasonboard.com">umang.jain@ideasonboard.com</a>><br>> > ---<br>> >  src/android/camera_stream.h | 2 +-<br>> >  1 file changed, 1 insertion(+), 1 deletion(-)<br>> ><br>> > diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h<br>> > index f68fdd3a..34016722 100644<br>> > --- a/src/android/camera_stream.h<br>> > +++ b/src/android/camera_stream.h<br>> > @@ -19,7 +19,7 @@<br>> >  #include <libcamera/geometry.h><br>> >  #include <libcamera/pixel_format.h><br>> ><br>> > -#include <libcamera/internal/buffer.h><br>> > +#include "libcamera/internal/buffer.h"<br>> ><br>> >  class CameraDevice;<br>> >  class CameraMetadata;<br>> > --<br>> > 2.29.2<br>> ><br>> > _______________________________________________<br>> > libcamera-devel mailing list<br>> > <a href="mailto:libcamera-devel@lists.libcamera.org">libcamera-devel@lists.libcamera.org</a><br>> > <a href="https://lists.libcamera.org/listinfo/libcamera-devel">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>><br>> --<br>> Regards,<br>> Niklas Söderlund<br>> _______________________________________________<br>> libcamera-devel mailing list<br>> <a href="mailto:libcamera-devel@lists.libcamera.org">libcamera-devel@lists.libcamera.org</a><br>> <a href="https://lists.libcamera.org/listinfo/libcamera-devel">https://lists.libcamera.org/listinfo/libcamera-devel</a></div></div>