<div dir="ltr"><div dir="ltr">Hi Jacopo, thank you for the patch.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 3, 2021 at 7:56 PM Niklas Söderlund <<a href="mailto:niklas.soderlund@ragnatech.se">niklas.soderlund@ragnatech.se</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Jacopo,<br>
<br>
Thanks for your work.<br>
<br>
On 2021-05-03 11:27:02 +0200, Jacopo Mondi wrote:<br>
> Apply to calculateBDSHeight() function the first hunk of commit 243d134<br>
> ("Fix some bug for some resolutions") from<br>
> <a href="https://github.com/intel/intel-ipu3-pipecfg.git" rel="noreferrer" target="_blank">https://github.com/intel/intel-ipu3-pipecfg.git</a>.<br>
> <br>
> The condition for the computed IF rectangle height to be matched<br>
> against the desired alignment now makes sure that it is included<br>
> in the minimum and maximum acceptable values.<br>
> <br>
> Tested-by: Jean-Michel Hautbois <<a href="mailto:jeanmichel.hautbois@ideasonboard.com" target="_blank">jeanmichel.hautbois@ideasonboard.com</a>><br>
> Reviewed-by: Jean-Michel Hautbois <<a href="mailto:jeanmichel.hautbois@ideasonboard.com" target="_blank">jeanmichel.hautbois@ideasonboard.com</a>><br>
> Signed-off-by: Jacopo Mondi <<a href="mailto:jacopo@jmondi.org" target="_blank">jacopo@jmondi.org</a>><br>
<br>
Acked-by: Niklas Söderlund <<a href="mailto:niklas.soderlund@ragnatech.se" target="_blank">niklas.soderlund@ragnatech.se</a>><br>
<br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> ---<br>
>  src/libcamera/pipeline/ipu3/imgu.cpp | 6 ++++--<br>
>  1 file changed, 4 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp<br>
> index ea654e57b0e7..feee2cc55abd 100644<br>
> --- a/src/libcamera/pipeline/ipu3/imgu.cpp<br>
> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp<br>
> @@ -135,7 +135,8 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc<br>
>               estIFHeight = std::clamp<float>(estIFHeight, minIFHeight, iif.height);<br>
>  <br>
>               ifHeight = utils::alignUp(estIFHeight, IF_ALIGN_H);<br>
> -             while (ifHeight >= minIFHeight && ifHeight / bdsSF >= minBDSHeight) {<br>
> +             while (ifHeight >= minIFHeight && ifHeight <= iif.height &&<br>
> +                    ifHeight / bdsSF >= minBDSHeight) {<br>
>  <br>
>                       bdsHeight = ifHeight / bdsSF;<br>
>                       if (std::fmod(bdsHeight, 1.0) == 0) {<br>
> @@ -151,7 +152,8 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc<br>
>               }<br>
>  <br>
>               ifHeight = utils::alignUp(estIFHeight, IF_ALIGN_H);<br>
> -             while (ifHeight <= iif.height && ifHeight / bdsSF >= minBDSHeight) {<br>
> +             while (ifHeight >= minIFHeight && ifHeight <= iif.height &&<br>
> +                    ifHeight / bdsSF >= minBDSHeight) {<br>
>  <br>
>                       bdsHeight = ifHeight / bdsSF;<br>
>                       if (std::fmod(bdsHeight, 1.0) == 0) {<br>
> -- <br>
> 2.31.1<br>
> <br>
> _______________________________________________<br>
> libcamera-devel mailing list<br>
> <a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
> <a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
<br>
-- <br>
Regards,<br>
Niklas Söderlund<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>