<div dir="ltr"><div dir="ltr">Hi Jacopo, thank you for the patch.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 4, 2021 at 5:13 PM Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com">kieran.bingham@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Jacopo,<br>
<br>
On 03/05/2021 11:41, Jacopo Mondi wrote:<br>
> When a Request is completed upon receiving the IPA produced metadata,<br>
> they should be merged with the metadata set by the pipeline handler<br>
> before reporting them to applications.<br>
> <br>
> Use ControlList::merge() to collect the IPA produced controls to the<br>
> request's metadata.<br>
> <br>
> Signed-off-by: Jacopo Mondi <<a href="mailto:jacopo@jmondi.org" target="_blank">jacopo@jmondi.org</a>><br>
<br>
Aha great, thank you - Good to have consistency here, even if we haven't<br>
yet started adding metadata to this ipa.<br>
<br>
Reviewed-by: Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a>><br>
<br>
> ---<br>
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +----<br>
>  1 file changed, 1 insertion(+), 4 deletions(-)<br>
> <br>
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> index 88b7bd1e52c3..ade8ffbddb0e 100644<br>
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> @@ -1190,11 +1190,8 @@ void IPU3CameraData::queueFrameAction(unsigned int id,<br>
>               if (!info)<br>
>                       break;<br>
>  <br>
> -             /*<br>
> -              * \todo Parse the value of the controls returned by the IPA<br>
> -              * in action.controls to register additional metadata.<br>
> -              */<br>
>               Request *request = info->request;<br>
> +             request->metadata().merge(action.controls);<br>
>  <br>
>               info->metadataProcessed = true;<br>
>               if (frameInfos_.tryComplete(info))<br>
> <br>
<br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-- <br>
Regards<br>
--<br>
Kieran<br>
_______________________________________________<br>
libcamera-devel mailing list<br>
<a href="mailto:libcamera-devel@lists.libcamera.org" target="_blank">libcamera-devel@lists.libcamera.org</a><br>
<a href="https://lists.libcamera.org/listinfo/libcamera-devel" rel="noreferrer" target="_blank">https://lists.libcamera.org/listinfo/libcamera-devel</a><br>
</blockquote></div></div>