<div dir="ltr"><div dir="ltr">Hi Laurent,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 16, 2021 at 3:38 AM Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The sizeofT argument to CameraMetadata::addEntry() stores the size of<br>
one element. Its name is a bit cryptic as the function isn't a template<br>
function with a typename T. Rename it to elementSize.<br>
<br>
Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
src/android/camera_metadata.cpp | 4 ++--<br>
src/android/camera_metadata.h | 3 ++-<br>
2 files changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp<br>
index bf8d2781cc21..59366c50cc16 100644<br>
--- a/src/android/camera_metadata.cpp<br>
+++ b/src/android/camera_metadata.cpp<br>
@@ -110,12 +110,12 @@ bool CameraMetadata::resize(size_t count, size_t size)<br>
}<br>
<br>
bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count,<br>
- size_t sizeofT)<br>
+ size_t elementSize)<br>
{<br>
if (!valid_)<br>
return false;<br>
<br>
- if (!resize(1, count * sizeofT)) {<br>
+ if (!resize(1, count * elementSize)) {<br>
LOG(CameraMetadata, Error) << "Failed to resize";<br>
valid_ = false;<br>
return false;<br>
diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h<br>
index 07afd4b25ae7..56df6f1c9008 100644<br>
--- a/src/android/camera_metadata.h<br>
+++ b/src/android/camera_metadata.h<br>
@@ -72,7 +72,8 @@ public:<br>
return updateEntry(tag, data.data(), data.size());<br>
}<br>
<br>
- bool addEntry(uint32_t tag, const void *data, size_t count, size_t sizeofT);<br>
+ bool addEntry(uint32_t tag, const void *data, size_t count,<br>
+ size_t elementSize);<br>
bool updateEntry(uint32_t tag, const void *data, size_t count);<br>
<br>
camera_metadata_t *get();<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
<br>
</blockquote></div></div>