<div dir="ltr"><div dir="ltr">Hi Laurent,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 16, 2021 at 3:38 AM Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The resize() function and the addEntry() override that takes a void<br>
pointer are not meant to be called by the user of the CameraMetadata<br>
class. Make them private.<br>
<br>
Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
src/android/camera_metadata.h | 7 ++++---<br>
1 file changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h<br>
index f95c34581fe4..d7c8d9df689f 100644<br>
--- a/src/android/camera_metadata.h<br>
+++ b/src/android/camera_metadata.h<br>
@@ -24,7 +24,6 @@ public:<br>
CameraMetadata &operator=(const CameraMetadata &other);<br>
<br>
bool isValid() const { return valid_; }<br>
- bool resize(size_t count, size_t size);<br>
bool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;<br>
<br>
template<typename T,<br>
@@ -72,14 +71,16 @@ public:<br>
return updateEntry(tag, data.data(), data.size());<br>
}<br>
<br>
- bool addEntry(uint32_t tag, const void *data, size_t count,<br>
- size_t elementSize);<br>
bool updateEntry(uint32_t tag, const void *data, size_t count);<br>
<br>
camera_metadata_t *get();<br>
const camera_metadata_t *get() const;<br>
<br>
private:<br>
+ bool resize(size_t count, size_t size);<br>
+ bool addEntry(uint32_t tag, const void *data, size_t count,<br>
+ size_t elementSize);<br>
+<br>
camera_metadata_t *metadata_;<br>
bool valid_;<br>
};<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
<br>
</blockquote></div></div>