<div dir="ltr"><div dir="ltr">Hi Laurent, thank you for the patch.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 24, 2021 at 11:43 AM Umang Jain <<a href="mailto:umang.jain@ideasonboard.com">umang.jain@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Laurent,<br>
<br>
Thanks for the patch<br>
<br>
On 5/23/21 8:01 AM, Laurent Pinchart wrote:<br>
> The Thread::dispatchMessages() function is meant to be called from<br>
> within the thread only. Catch incorrect usage with an ASSERT().<br>
><br>
> Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
Reviewed-by: Umang Jain <<a href="mailto:umang.jain@ideasonboard.com" target="_blank">umang.jain@ideasonboard.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> ---<br>
>   src/libcamera/thread.cpp | 2 ++<br>
>   1 file changed, 2 insertions(+)<br>
><br>
> diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp<br>
> index 285b808332e8..bc1dcedea0d1 100644<br>
> --- a/src/libcamera/thread.cpp<br>
> +++ b/src/libcamera/thread.cpp<br>
> @@ -560,6 +560,8 @@ void Thread::removeMessages(Object *receiver)<br>
>    */<br>
>   void Thread::dispatchMessages(Message::Type type)<br>
>   {<br>
> +     ASSERT(data_ == ThreadData::current());<br>
> +<br>
>       MutexLocker locker(data_->messages_.mutex_);<br>
>   <br>
>       std::list<std::unique_ptr<Message>> &messages = data_->messages_.list_;<br>
<br>
</blockquote></div></div>