<div dir="ltr"><div dir="ltr">Hi Paul, thank you for the patch.<div><br></div></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 23, 2021 at 9:17 AM Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, May 21, 2021 at 01:55:14PM +0200, Jacopo Mondi wrote:<br>
> On Fri, May 21, 2021 at 07:55:34PM +0900, Paul Elder wrote:<br>
> > The sensor frame duration should be set by the IPA. Hardcode it for now.<br>
> ><br>
> > Signed-off-by: Paul Elder <<a href="mailto:paul.elder@ideasonboard.com" target="_blank">paul.elder@ideasonboard.com</a>><br>
> <br>
> With a \todo<br>
> <br>
> Reviewed-by: Jacopo Mondi <<a href="mailto:jacopo@jmondi.org" target="_blank">jacopo@jmondi.org</a>><br>
<br>
Ditto, the todo is important.<br>
<br>
Reviewed-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
<br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> > ---<br>
> >  src/ipa/ipu3/ipu3.cpp | 4 ++++<br>
> >  1 file changed, 4 insertions(+)<br>
> ><br>
> > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp<br>
> > index f5343547..35c24052 100644<br>
> > --- a/src/ipa/ipu3/ipu3.cpp<br>
> > +++ b/src/ipa/ipu3/ipu3.cpp<br>
> > @@ -269,6 +269,10 @@ void IPAIPU3::parseStatistics(unsigned int frame,<br>
> >     if (agcAlgo_->updateControls())<br>
> >             setControls(frame);<br>
> ><br>
> > +   ctrls.set(controls::FrameDurations,<br>
> > +             { static_cast<int64_t>(33334),<br>
> > +               static_cast<int64_t>(33334) });<br>
> > +<br>
> >     IPU3Action op;<br>
> >     op.op = ActionMetadataReady;<br>
> >     op.controls = ctrls;<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>