<div dir="ltr"><div dir="ltr">Hi Umang, thank you for reviewing.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 26, 2021 at 10:40 PM Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Umang,<br>
<br>
Thank you for the patch.<br>
<br>
On Wed, May 26, 2021 at 06:40:24PM +0530, Umang Jain wrote:<br>
> Fixes: 2fac95b400b7 ("libcamera: pipeline: ipu3: Ensure that IPU3Frames::info is not used after delete")<br>
> Signed-off-by: Umang Jain <<a href="mailto:umang.jain@ideasonboard.com" target="_blank">umang.jain@ideasonboard.com</a>><br>
<br>
Reviewed-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
<br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> ---<br>
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++---<br>
>  1 file changed, 3 insertions(+), 3 deletions(-)<br>
> <br>
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> index 25203256..750880ed 100644<br>
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> @@ -1361,9 +1361,9 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)<br>
>               info->metadataProcessed = true;<br>
>  <br>
>               /*<br>
> -             * tryComplete() will delete info if it completes the IPU3Frame.<br>
> -             * In that event, we must have obtained the Request before hand.<br>
> -             */<br>
> +              * tryComplete() will delete info if it completes the IPU3Frame.<br>
> +              * In that event, we must have obtained the Request before hand.<br>
> +              */<br>
>               Request *request = info->request;<br>
>  <br>
>               if (frameInfos_.tryComplete(info))<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>