<div dir="ltr"><div dir="ltr">Hi Laurent,</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 27, 2021 at 11:52 AM Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Hiro,<br>
<br>
On Thu, May 27, 2021 at 11:49:10AM +0900, Hirokazu Honda wrote:<br>
> On Thu, May 27, 2021 at 10:02 AM Laurent Pinchart wrote:<br>
> <br>
> > The standard C library close() and lseek() functions require inclusion<br>
> > of the unistd.h header. Include it explicitly where needed instead of<br>
> > relying on indirect inclusion.<br>
> ><br>
> > Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
> <br>
> Do you know where unistd.h are indirectly included from?<br>
<br>
Android headers, as I noticed a compilation breakage when updating them<br>
:-)<br>
<br></blockquote><div><br></div><div>Acked. Thanks for fixing.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org" target="_blank">hiroh@chromium.org</a>><br>
> <br>
> > ---<br>
> >  src/android/camera_device.cpp            | 1 +<br>
> >  src/android/camera_worker.cpp            | 1 +<br>
> >  src/android/mm/generic_camera_buffer.cpp | 2 ++<br>
> >  3 files changed, 4 insertions(+)<br>
> ><br>
> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp<br>
> > index 7fc4ddb024c1..81509f57d1b7 100644<br>
> > --- a/src/android/camera_device.cpp<br>
> > +++ b/src/android/camera_device.cpp<br>
> > @@ -15,6 +15,7 @@<br>
> >  #include <fstream><br>
> >  #include <sys/mman.h><br>
> >  #include <tuple><br>
> > +#include <unistd.h><br>
> >  #include <vector><br>
> ><br>
> >  #include <libcamera/control_ids.h><br>
> > diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp<br>
> > index 9f727826e23f..98dddd9eb13b 100644<br>
> > --- a/src/android/camera_worker.cpp<br>
> > +++ b/src/android/camera_worker.cpp<br>
> > @@ -10,6 +10,7 @@<br>
> >  #include <errno.h><br>
> >  #include <string.h><br>
> >  #include <sys/poll.h><br>
> > +#include <unistd.h><br>
> ><br>
> >  #include "camera_device.h"<br>
> ><br>
> > diff --git a/src/android/mm/generic_camera_buffer.cpp<br>
> > b/src/android/mm/generic_camera_buffer.cpp<br>
> > index 334498c1867f..cca88cf3632f 100644<br>
> > --- a/src/android/mm/generic_camera_buffer.cpp<br>
> > +++ b/src/android/mm/generic_camera_buffer.cpp<br>
> > @@ -7,6 +7,8 @@<br>
> ><br>
> >  #include "../camera_buffer.h"<br>
> ><br>
> > +#include <unistd.h><br>
> > +<br>
> >  #include "libcamera/internal/buffer.h"<br>
> >  #include "libcamera/internal/log.h"<br>
> ><br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>