<div dir="ltr"><div dir="ltr">Hi Laurent, thank you for the patch.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 1, 2021 at 12:11 PM <<a href="mailto:paul.elder@ideasonboard.com">paul.elder@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Laurent,<br>
<br>
On Tue, Jun 01, 2021 at 01:53:28AM +0300, Laurent Pinchart wrote:<br>
> The Chrome OS-specific code has multiple function parameters that are<br>
> not used. This results in compilation warnings. Fix them with<br>
> [[maybe_unused]].<br>
> <br>
> Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
> Change-Id: I4f05ace5c1781b2593e80532553b6a02e399fed6<br>
<br>
Reviewed-by: Paul Elder <<a href="mailto:paul.elder@ideasonboard.com" target="_blank">paul.elder@ideasonboard.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> ---<br>
>  src/android/cros/camera3_hal.cpp      | 2 +-<br>
>  src/android/mm/cros_camera_buffer.cpp | 5 +++--<br>
>  2 files changed, 4 insertions(+), 3 deletions(-)<br>
> <br>
> diff --git a/src/android/cros/camera3_hal.cpp b/src/android/cros/camera3_hal.cpp<br>
> index d6fc1d0fca06..fb863b5f9aa9 100644<br>
> --- a/src/android/cros/camera3_hal.cpp<br>
> +++ b/src/android/cros/camera3_hal.cpp<br>
> @@ -9,7 +9,7 @@<br>
>  <br>
>  #include "../camera_hal_manager.h"<br>
>  <br>
> -static void set_up(cros::CameraMojoChannelManagerToken *token)<br>
> +static void set_up([[maybe_unused]] cros::CameraMojoChannelManagerToken *token)<br>
>  {<br>
>  }<br>
>  <br>
> diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp<br>
> index 1a4fd5d1dfe3..59e26d1b5972 100644<br>
> --- a/src/android/mm/cros_camera_buffer.cpp<br>
> +++ b/src/android/mm/cros_camera_buffer.cpp<br>
> @@ -48,7 +48,8 @@ private:<br>
>  };<br>
>  <br>
>  CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,<br>
> -                            buffer_handle_t camera3Buffer, int flags)<br>
> +                            buffer_handle_t camera3Buffer,<br>
> +                            [[maybe_unused]] int flags)<br>
>       : Extensible::Private(cameraBuffer), handle_(camera3Buffer),<br>
>         numPlanes_(0), valid_(false), registered_(false)<br>
>  {<br>
> @@ -128,7 +129,7 @@ Span<uint8_t> CameraBuffer::Private::plane(unsigned int plane)<br>
>                bufferManager_->GetPlaneSize(handle_, plane) };<br>
>  }<br>
>  <br>
> -size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize) const<br>
> +size_t CameraBuffer::Private::jpegBufferSize([[maybe_unused]] size_t maxJpegBufferSize) const<br>
>  {<br>
>       return bufferManager_->GetPlaneSize(handle_, 0);<br>
>  }<br>
</blockquote></div></div>