<div dir="ltr"><div dir="ltr">Hi Paul, thank you for the patch.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 17, 2021 at 2:08 PM Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Paul,<br>
<br>
Thank you for the patch.<br>
<br>
On Thu, Jun 17, 2021 at 01:57:13PM +0900, Paul Elder wrote:<br>
> There were some CameraMetadata calls that were left in the old version.<br>
> Update them.<br>
> <br>
> Signed-off-by: Paul Elder <<a href="mailto:paul.elder@ideasonboard.com" target="_blank">paul.elder@ideasonboard.com</a>><br>
<br>
Reviewed-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> ---<br>
>  src/android/camera_device.cpp | 7 +++----<br>
>  1 file changed, 3 insertions(+), 4 deletions(-)<br>
> <br>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp<br>
> index b8df7817..11d5c21b 100644<br>
> --- a/src/android/camera_device.cpp<br>
> +++ b/src/android/camera_device.cpp<br>
> @@ -931,7 +931,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()<br>
>               { 0, 1 }<br>
>       };<br>
>       staticMetadata_->addEntry(ANDROID_CONTROL_AE_COMPENSATION_STEP,<br>
> -                               aeCompensationStep, 1);<br>
> +                               aeCompensationStep);<br>
>  <br>
>       std::vector<uint8_t> availableAfModes = {<br>
>               ANDROID_CONTROL_AF_MODE_OFF,<br>
> @@ -1153,7 +1153,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()<br>
>       /* Statistics static metadata. */<br>
>       uint8_t faceDetectMode = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;<br>
>       staticMetadata_->addEntry(ANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,<br>
> -                               &faceDetectMode, 1);<br>
> +                               faceDetectMode);<br>
>  <br>
>       int32_t maxFaceCount = 0;<br>
>       staticMetadata_->addEntry(ANDROID_STATISTICS_INFO_MAX_FACE_COUNT,<br>
> @@ -1273,8 +1273,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()<br>
>                       ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);<br>
>       }<br>
>       staticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,<br>
> -                               availableStreamConfigurations.data(),<br>
> -                               availableStreamConfigurations.size());<br>
> +                               availableStreamConfigurations);<br>
>  <br>
>       std::vector<int64_t> availableStallDurations = {<br>
>               ANDROID_SCALER_AVAILABLE_FORMATS_BLOB, 2560, 1920, 33333333,<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>