<div dir="ltr"><div dir="ltr">HI Paul, thank you for the patch.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 17, 2021 at 1:58 PM Paul Elder <<a href="mailto:paul.elder@ideasonboard.com">paul.elder@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY. Set<br>
it.<br>
<br>
Signed-off-by: Paul Elder <<a href="mailto:paul.elder@ideasonboard.com" target="_blank">paul.elder@ideasonboard.com</a>><br>
Reviewed-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
<br>
---<br>
This on its own doesn't fix any CTS tests, but it prevents a test<br>
failure later on when we add the proper static metadata for the FULL<br>
hardware level.<br>
---<br>
 src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-<br>
 1 file changed, 4 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp<br>
index 058ccc99..921ac823 100644<br>
--- a/src/android/jpeg/post_processor_jpeg.cpp<br>
+++ b/src/android/jpeg/post_processor_jpeg.cpp<br>
@@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const FrameBuffer &source,<br>
        ret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &entry);<br>
        if (ret)<br>
                exif.setAperture(*entry.data.f);<br>
-       exif.setISO(100);<br>
+<br>
+       ret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY, &entry);<br>
+       exif.setISO(ret ? *entry.data.i32 : 100);<br></blockquote><div><br></div><div>Noob: where does 100 come from?</div><div><br></div><div>Reviewed-by: Hirokazu Honda <<a href="mailto:hiroh@chromium.org">hiroh@chromium.org</a>> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+<br>
        exif.setFlash(Exif::Flash::FlashNotPresent);<br>
        exif.setWhiteBalance(Exif::WhiteBalance::Auto);<br>
<br>
-- <br>
2.27.0<br>
<br>
</blockquote></div></div>