<div dir="auto">Hi Paul,<div dir="auto">Will make the changes</div><div dir="auto"><br></div><div dir="auto">Regards,</div><div dir="auto">Vedant</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 11 Aug, 2021, 07:11 , <<a href="mailto:paul.elder@ideasonboard.com">paul.elder@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Vedant,<br>
<br>
On Tue, Aug 10, 2021 at 04:48:47PM +0530, Vedant Paranjape wrote:<br>
> This patch adds a test to test if single stream using<br>
> libcamera's gstreamer element works.<br>
> <br>
> Signed-off-by: Vedant Paranjape <<a href="mailto:vedantparanjape160201@gmail.com" target="_blank" rel="noreferrer">vedantparanjape160201@gmail.com</a>><br>
> ---<br>
> .../gstreamer_single_stream_test.cpp | 114 ++++++++++++++++++<br>
> test/gstreamer/meson.build | 19 +++<br>
> test/meson.build | 1 +<br>
> 3 files changed, 134 insertions(+)<br>
> create mode 100644 test/gstreamer/gstreamer_single_stream_test.cpp<br>
> create mode 100644 test/gstreamer/meson.build<br>
> <br>
> diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp<br>
> new file mode 100644<br>
> index 00000000..53bd6897<br>
> --- /dev/null<br>
> +++ b/test/gstreamer/gstreamer_single_stream_test.cpp<br>
> @@ -0,0 +1,114 @@<br>
> +#include <gst/gst.h><br>
> +#include <iostream><br>
> +<br>
> +#include "test.h"<br>
> +<br>
> +using namespace std;<br>
> +<br>
> +class GstreamerSingleStreamTest : public Test<br>
> +{<br>
> +protected:<br>
> + void GstreamerPrintError(GstMessage *msg)<br>
<br>
This should be private.<br>
<br>
> + {<br>
> + GError *err;<br>
> + gchar *debug_info;<br>
> +<br>
> + gst_message_parse_error(msg, &err, &debug_info);<br>
> + g_printerr("Error received from element %s: %s\n", GST_OBJECT_NAME(msg->src), err->message);<br>
> + g_printerr("Debugging information: %s\n", debug_info ? debug_info : "none");<br>
<br>
These two lines should be broken up:<br>
<br>
+ g_printerr("Error received from element %s: %s\n",<br>
+ GST_OBJECT_NAME(msg->src), err->message);<br>
+ g_printerr("Debugging information: %s\n",<br>
+ debug_info ? debug_info : "none");<br>
<br>
> + g_clear_error(&err);<br>
> + g_free(debug_info);<br>
> + }<br>
> +<br>
> + int init() override<br>
> + {<br>
> + /* Initialize GStreamer */<br>
> + GError *err_init = nullptr;<br>
> + if (!gst_init_check(nullptr, nullptr, &err_init)) {<br>
> + g_printerr("Could not initialize GStreamer: %s\n",<br>
> + err_init ? err_init->message : "unknown error");<br>
> + if (err_init)<br>
> + g_error_free(err_init);<br>
> +<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + /* Create the elements */<br>
> + libcamera_src_ = gst_element_factory_make("libcamerasrc", "libcamera");<br>
> + convert0_ = gst_element_factory_make("videoconvert", "convert0");<br>
> + sink0_ = gst_element_factory_make("autovideosink", "sink0");<br>
> +<br>
> + /* Create the empty pipeline_ */<br>
> + pipeline_ = gst_pipeline_new("test-pipeline");<br>
> +<br>
> + if (!pipeline_ || !convert0_ || !sink0_ || !libcamera_src_) {<br>
> + g_printerr("Not all elements could be created.\n");<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + return TestPass;<br>
> + }<br>
> +<br>
> + void cleanup() override<br>
> + {<br>
> + gst_message_unref(msg_);<br>
> + gst_object_unref(bus_);<br>
> + gst_element_set_state(pipeline_, GST_STATE_NULL);<br>
> + gst_object_unref(pipeline_);<br>
> + }<br>
> +<br>
> + int run() override<br>
> + {<br>
> + /* Build the pipeline */<br>
> + gst_bin_add_many(GST_BIN(pipeline_), libcamera_src_, convert0_, sink0_, NULL);<br>
> + if (gst_element_link_many(libcamera_src_, convert0_, sink0_, NULL) != TRUE) {<br>
<br>
Same here.<br>
<br>
> + g_printerr("Elements could not be linked.\n");<br>
> + gst_object_unref(pipeline_);<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + /* Start playing */<br>
> + ret_ = gst_element_set_state(pipeline_, GST_STATE_PLAYING);<br>
> + if (ret_ == GST_STATE_CHANGE_FAILURE) {<br>
> + g_printerr("Unable to set the pipeline to the playing state.\n");<br>
> + gst_object_unref(pipeline_);<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + /* Wait until error or EOS or timeout after 2 seconds*/<br>
> + GstClockTime timeout = 2000000000;<br>
> + bus_ = gst_element_get_bus(pipeline_);<br>
> + msg_ = gst_bus_timed_pop_filtered(bus_, timeout,<br>
> + GstMessageType((uint)GST_MESSAGE_ERROR | (uint)GST_MESSAGE_EOS));<br>
<br>
I know checkstyle does this, but imo it's shifted way too much over; I<br>
think just simply one tab in is fine:<br>
<br>
+ msg_ = gst_bus_timed_pop_filtered(bus_, timeout,<br>
+ GstMessageType((uint)GST_MESSAGE_ERROR | (uint)GST_MESSAGE_EOS));<br>
<br>
<br>
Other than that, looks good to me.<br>
<br>
Reviewed-by: Paul Elder <<a href="mailto:paul.elder@ideasonboard.com" target="_blank" rel="noreferrer">paul.elder@ideasonboard.com</a>><br>
<br>
> +<br>
> + /* Parse error message */<br>
> + if (msg_ == NULL)<br>
> + return TestPass;<br>
> +<br>
> + switch (GST_MESSAGE_TYPE(msg_)) {<br>
> + case GST_MESSAGE_ERROR:<br>
> + GstreamerPrintError(msg_);<br>
> + return TestFail;<br>
> + break;<br>
> + case GST_MESSAGE_EOS:<br>
> + g_print("End-Of-Stream reached.\n");<br>
> + return TestFail;<br>
> + break;<br>
> + default:<br>
> + g_printerr("Unexpected message received.\n");<br>
> + return TestFail;<br>
> + break;<br>
> + }<br>
> +<br>
> + return TestPass;<br>
> + }<br>
> +<br>
> +private:<br>
> + GstElement *pipeline_, *libcamera_src_, *convert0_, *sink0_;<br>
> + GstBus *bus_;<br>
> + GstMessage *msg_;<br>
> + GstStateChangeReturn ret_;<br>
> +};<br>
> +<br>
> +TEST_REGISTER(GstreamerSingleStreamTest)<br>
> +<br>
> diff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build<br>
> new file mode 100644<br>
> index 00000000..b99aa0da<br>
> --- /dev/null<br>
> +++ b/test/gstreamer/meson.build<br>
> @@ -0,0 +1,19 @@<br>
> +# SPDX-License-Identifier: CC0-1.0<br>
> +<br>
> +if not gst_enabled<br>
> + subdir_done()<br>
> +endif<br>
> +<br>
> +gstreamer_tests = [<br>
> + ['single_stream_test', 'gstreamer_single_stream_test.cpp'],<br>
> +]<br>
> +gstreamer_dep = dependency('gstreamer-1.0', required: true)<br>
> +<br>
> +foreach t : gstreamer_tests<br>
> + exe = executable(t[0], t[1],<br>
> + dependencies : [libcamera_private, gstreamer_dep],<br>
> + link_with : test_libraries,<br>
> + include_directories : test_includes_internal)<br>
> +<br>
> + test(t[0], exe, suite : 'gstreamer', is_parallel : false)<br>
> +endforeach<br>
> diff --git a/test/meson.build b/test/meson.build<br>
> index 3bceb5df..d0466f17 100644<br>
> --- a/test/meson.build<br>
> +++ b/test/meson.build<br>
> @@ -11,6 +11,7 @@ subdir('libtest')<br>
> <br>
> subdir('camera')<br>
> subdir('controls')<br>
> +subdir('gstreamer')<br>
> subdir('ipa')<br>
> subdir('ipc')<br>
> subdir('log')<br>
> -- <br>
> 2.25.1<br>
> <br>
</blockquote></div>