<div dir="ltr"><div dir="ltr"><div>Hi Kieran,</div><div>Thanks for the review.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 13, 2021 at 1:48 PM Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com">kieran.bingham@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Vedant,<br>
<br>
On 13/08/2021 07:37, Vedant Paranjape wrote:<br>
> This patch adds a test to test if single stream using<br>
> libcamera's gstreamer element works.<br>
> <br>
> Signed-off-by: Vedant Paranjape <<a href="mailto:vedantparanjape160201@gmail.com" target="_blank">vedantparanjape160201@gmail.com</a>><br>
> Reviewed-by: Paul Elder <<a href="mailto:paul.elder@ideasonboard.com" target="_blank">paul.elder@ideasonboard.com</a>><br>
> ---<br>
> .../gstreamer_single_stream_test.cpp | 148 ++++++++++++++++++<br>
> test/gstreamer/meson.build | 19 +++<br>
> test/meson.build | 1 +<br>
> 3 files changed, 168 insertions(+)<br>
> create mode 100644 test/gstreamer/gstreamer_single_stream_test.cpp<br>
> create mode 100644 test/gstreamer/meson.build<br>
> <br>
> diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp<br>
> new file mode 100644<br>
> index 00000000..c0d38ff8<br>
> --- /dev/null<br>
> +++ b/test/gstreamer/gstreamer_single_stream_test.cpp<br>
> @@ -0,0 +1,148 @@<br>
> +/* SPDX-License-Identifier: GPL-2.0-or-later */<br>
> +/*<br>
> + * Copyright (C) 2021, Vedant Paranjape<br>
> + *<br>
> + * ipa_interface_test.cpp - Test the IPA interface<br>
> + */<br>
> +<br>
> +#include <iostream><br>
> +<br>
> +#include <libcamera/base/utils.h><br>
> +<br>
> +#include <gst/gst.h><br>
> +<br>
> +#include "test.h"<br>
> +<br>
> +using namespace std;<br>
> +<br>
> +class GstreamerSingleStreamTest : public Test<br>
> +{<br>
> +protected:<br>
> + int init() override<br>
> + {<br>
> + /* Initialize GStreamer */<br>
> + GError *errInit = nullptr;<br>
> + if (!gst_init_check(nullptr, nullptr, &errInit)) {<br>
> + g_printerr("Could not initialize GStreamer: %s\n",<br>
> + errInit ? errInit->message : "unknown error");<br>
> + if (errInit)<br>
> + g_error_free(errInit);<br>
> +<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + /*<br>
> + * Remove the system libcamera plugin, if any, and add the<br>
> + * plugin from the build directory.<br>
> + */<br>
<br>
Oh - excellent, I like this a lot as it will help make sure the test<br>
runs what we expect it to run.<br>
<br>
> + GstRegistry *registry = gst_registry_get();<br>
> + GstPlugin *plugin = gst_registry_lookup(registry, "libgstlibcamera.so");<br>
> + if (plugin) {<br>
> + gst_registry_remove_plugin(registry, plugin);<br>
> + gst_object_unref(plugin);<br>
> + }<br>
> + <br>
> + std::string path = std::string(libcamera::utils::libcameraBuildPath()<br>
> + + "src/gstreamer");<br>
> + if (!gst_registry_scan_path(registry, path.c_str())) {<br>
> + g_printerr("Failed to add plugin to registry\n");<br>
> + gst_deinit();<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + /* Create the elements */<br>
> + libcameraSrc_ = gst_element_factory_make("libcamerasrc", "libcamera");<br>
> + convert0_ = gst_element_factory_make("videoconvert", "convert0");<br>
> + sink0_ = gst_element_factory_make("fakevideosink", "sink0");<br>
> +<br>
> + /* Create the empty pipeline_ */<br>
> + pipeline_ = gst_pipeline_new("test-pipeline");<br>
> +<br>
> + if (!pipeline_ || !convert0_ || !sink0_ || !libcameraSrc_) {<br>
> + g_printerr("Not all elements could be created.\n");<br>
<br>
I still get failures here:<br>
<br>
> ./build/test/gstreamer/single_stream_test<br>
> Not all elements could be created.<br>
> <br>
> (single_stream_test:3346990): GStreamer-CRITICAL **: 09:04:43.279: gst_object_unref: assertion 'object != NULL' failed<br>
<br>
Changing this line, makes it clearer what actually has failed, so<br>
perhaps we should be a bit more verbose on this error print.<br>
<br>
> - g_printerr("Not all elements could be created.\n");<br>
> + g_printerr("Not all elements could be created. %p.%p.%p.%p\n",<br>
> + pipeline_, convert0_, sink0_, libcameraSrc_);<br>
<br>
So now I can see:<br>
<br>
> Not all elements could be created. 0x55d7a51a2100.0x55d7a519db20.(nil).0x55d7a518f0a0<br>
<br>
sink0_ has failed on my system. That's ... unexpected and surprising....<br>
<br>
gst-inspect-1.0 | grep fakesink<br>
coreelements: fakesink: Fake Sink<br>
<br>
gst-inspect-1.0 | grep fakevideosink<br>
<nothing><br>
<br>
So - my system has a fakesink, but not a fakevideosink.<br>
<br>
Is it preferable to use a fakevideosink? Should we always use a<br>
fakesink, or try to make either a fakesink or a fakevideosink, and then<br>
choose the first one we make?<br></blockquote><div><br></div><div>But it's wierd for you to not have fakevideosink installed, can you install it from gst-plugins-bad and Nicolas is the author of that. Since fakesink is packaged with gstreamer installation, and fakevideosink needs gst-plugins-bad, I'll just stick with fakesink to reduce dependency.</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I would ask if we use fakesink, we might not need the videoconvert - but<br>
I actually think having that puts some level of 'make sure the<br>
libcamerasrc' element is configured as a video source, so I think it's<br>
good to have.<br>
<br>
<br>
> + gst_object_unref(pipeline_);<br>
> + gst_object_unref(convert0_);<br>
> + gst_object_unref(sink0_);<br>
> + gst_object_unref(libcameraSrc_);<br>
<br>
By very definition of entering this conditional section, at least one of<br>
those four lines will cause a null-unref assertion failure.<br></blockquote><div><br></div><div>> cleanup() isn't called if init() fails, so you need to unref pipeline_,<br>
> but also libcamera_src_, convert0_ and sink0_ here. The last three<br>
> elements don't need to be unrefered in cleanup(), because<br>
> gst_bin_add_many() makes the pipeline take ownership of them.<br></div><div> <br></div><div>This is what Laurent said, I looked up the docs, and gst_element_factory_make returns a floating reference</div><div><br></div><div>> <b>Returns</b>
<span>(</span>
<span class="gmail-annotation">[<abbr title="Alias for transfer none, used for objects with floating refs"><span class="gmail-acronym">transfer: floating</span></abbr>]</span><span class="gmail-annotation">[<abbr title="NULL may be passed to the value"><span class="gmail-acronym">nullable</span></abbr>]</span><span>)</span>
– new <a href="https://gstreamer.freedesktop.org/documentation/gstreamer/gstelement.html#GstElement">GstElement</a> or <a href="https://developer.gnome.org/glib/unstable/glib-Standard-Macros.html#NULL:CAPS">NULL</a>
if unable to create element</div><div><br></div><div>I guess I can just remove these four unrefs ?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Anyway, with those issues resolved, I think this is so close, and<br>
certainly a great addition.<br>
<br>
So with those issues fixed,<br>
<br>
Reviewed-by: Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a>><br>
<br>
Looking forward to be able to give a Tested-by: tag too on the next<br>
version ;-)<br>
<br>
--<br>
Kieran<br>
<br>
> + gst_deinit();<br>
> +<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + return TestPass;<br>
> + }<br>
> +<br>
> + void cleanup() override<br>
> + {<br>
> + gst_object_unref(pipeline_);<br>
> + gst_deinit();<br>
> + }<br>
> +<br>
> + int run() override<br>
> + {<br>
> + GstStateChangeReturn ret;<br>
> + g_autoptr(GstBus) bus;<br>
> + g_autoptr(GstMessage) msg;<br>
> +<br>
> + /* Build the pipeline */<br>
> + gst_bin_add_many(GST_BIN(pipeline_), libcameraSrc_, convert0_, sink0_, NULL);<br>
> + if (gst_element_link_many(libcameraSrc_, convert0_, sink0_, NULL) != TRUE) {<br>
> + g_printerr("Elements could not be linked.\n");<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + /* Start playing */<br>
> + ret = gst_element_set_state(pipeline_, GST_STATE_PLAYING);<br>
> + if (ret == GST_STATE_CHANGE_FAILURE) {<br>
> + g_printerr("Unable to set the pipeline to the playing state.\n");<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> + /* Wait until error or EOS or timeout after 2 seconds */<br>
> + GstClockTime timeout = 2000000000;<br>
> + bus = gst_element_get_bus(pipeline_);<br>
> + msg = gst_bus_timed_pop_filtered(bus, timeout,<br>
> + GstMessageType((uint)GST_MESSAGE_ERROR | (uint)GST_MESSAGE_EOS));<br>
> + gst_element_set_state(pipeline_, GST_STATE_NULL);<br>
> +<br>
> + /* Parse error message */<br>
> + if (msg == NULL)<br>
> + return TestPass;<br>
> +<br>
> + switch (GST_MESSAGE_TYPE(msg)) {<br>
> + case GST_MESSAGE_ERROR:<br>
> + gstreamer_print_error(msg);<br>
> + break;<br>
> + case GST_MESSAGE_EOS:<br>
> + g_print("End-Of-Stream reached.\n");<br>
> + break;<br>
> + default:<br>
> + g_printerr("Unexpected message received.\n");<br>
> + break;<br>
> + }<br>
> +<br>
> + return TestFail;<br>
> + }<br>
> +<br>
> +private:<br>
> + void gstreamer_print_error(GstMessage *msg)<br>
> + {<br>
> + GError *err;<br>
> + gchar *debug_info;<br>
> +<br>
> + gst_message_parse_error(msg, &err, &debug_info);<br>
> + g_printerr("Error received from element %s: %s\n",<br>
> + GST_OBJECT_NAME(msg->src), err->message);<br>
> + g_printerr("Debugging information: %s\n",<br>
> + debug_info ? debug_info : "none");<br>
> + g_clear_error(&err);<br>
> + g_free(debug_info);<br>
> + }<br>
> +<br>
> + GstElement *pipeline_;<br>
> + GstElement *libcameraSrc_;<br>
> + GstElement *convert0_;<br>
> + GstElement *sink0_;<br>
> +};<br>
> +<br>
> +TEST_REGISTER(GstreamerSingleStreamTest)<br>
> diff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build<br>
> new file mode 100644<br>
> index 00000000..b99aa0da<br>
> --- /dev/null<br>
> +++ b/test/gstreamer/meson.build<br>
> @@ -0,0 +1,19 @@<br>
> +# SPDX-License-Identifier: CC0-1.0<br>
> +<br>
> +if not gst_enabled<br>
> + subdir_done()<br>
> +endif<br>
> +<br>
> +gstreamer_tests = [<br>
> + ['single_stream_test', 'gstreamer_single_stream_test.cpp'],<br>
> +]<br>
> +gstreamer_dep = dependency('gstreamer-1.0', required: true)<br>
> +<br>
> +foreach t : gstreamer_tests<br>
> + exe = executable(t[0], t[1],<br>
> + dependencies : [libcamera_private, gstreamer_dep],<br>
> + link_with : test_libraries,<br>
> + include_directories : test_includes_internal)<br>
> +<br>
> + test(t[0], exe, suite : 'gstreamer', is_parallel : false)<br>
> +endforeach<br>
> diff --git a/test/meson.build b/test/meson.build<br>
> index 3bceb5df..d0466f17 100644<br>
> --- a/test/meson.build<br>
> +++ b/test/meson.build<br>
> @@ -11,6 +11,7 @@ subdir('libtest')<br>
> <br>
> subdir('camera')<br>
> subdir('controls')<br>
> +subdir('gstreamer')<br>
> subdir('ipa')<br>
> subdir('ipc')<br>
> subdir('log')<br>
> <br></blockquote><div><br></div><div>Regards,</div><div>Vedant<br></div></div></div>