<div dir="ltr"><div>Hey, I think you have the wrong patch. I sent a v5 just some hours back, it fixed all the issues shown here.</div><div><br></div><div>Regards,</div><div><i><b>Vedant Paranjape</b></i><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 9, 2021 at 7:35 PM Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com">kieran.bingham@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Vedant,<br>
<br>
These reports have been generated by Coverity.<br>
They may be false positives, but just so you're aware in case they are<br>
an issue.<br>
<br>
--<br>
Kieran<br>
<br>
<br>
<br>
-------- Forwarded Message --------<br>
Subject: New Defects reported by Coverity Scan for libcamera<br>
Date: Thu, 09 Sep 2021 14:00:44 +0000 (UTC)<br>
From: <a href="mailto:scan-admin@coverity.com" target="_blank">scan-admin@coverity.com</a><br>
To: <a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a><br>
<br>
Hi,<br>
<br>
Please find the latest report on new defect(s) introduced to libcamera<br>
found with Coverity Scan.<br>
<br>
2 new defect(s) introduced to libcamera found with Coverity Scan.<br>
<br>
<br>
New defect(s) Reported-by: Coverity Scan<br>
Showing 2 of 2 defect(s)<br>
<br>
<br>
** CID 356329:    (UNINIT_CTOR)<br>
/home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_test.cpp:<br>
47 in GstreamerTest::GstreamerTest()()<br>
/home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_test.cpp:<br>
68 in GstreamerTest::GstreamerTest()()<br>
<br>
<br>
________________________________________________________________________________________________________<br>
*** CID 356329:    (UNINIT_CTOR)<br>
/home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_test.cpp:<br>
47 in GstreamerTest::GstreamerTest()()<br>
41      g_autoptr(GError) errInit = NULL;<br>
42      if (!gst_init_check(nullptr, nullptr, &errInit)) {<br>
43              g_printerr("Could not initialize GStreamer: %s\n",<br>
44                         errInit ? errInit->message : "unknown error");<br>
45     46               status_ = TestFail;<br>
>>>     CID 356329:    (UNINIT_CTOR)<br>
>>>     Non-static class member "libcameraSrc_" is not initialized in this constructor nor in any functions that it calls.<br>
47              return;<br>
48      }<br>
49     50       /*<br>
51      * Remove the system libcamera plugin, if any, and add the<br>
52      * plugin from the build directory.<br>
/home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_test.cpp:<br>
68 in GstreamerTest::GstreamerTest()()<br>
62     63               status_ = TestFail;<br>
64              return;<br>
65      }<br>
66     67       status_ = TestPass;<br>
>>>     CID 356329:    (UNINIT_CTOR)<br>
>>>     Non-static class member "libcameraSrc_" is not initialized in this constructor nor in any functions that it calls.<br>
68     }<br>
69     70     GstreamerTest::~GstreamerTest()<br>
71     {<br>
72      if (libcameraSrc_ &&<br>
73          !gst_object_has_as_ancestor(GST_OBJECT(libcameraSrc_),<br>
<br>
** CID 356328:  Uninitialized members  (UNINIT_CTOR)<br>
/home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_single_stream_test.cpp:<br>
28 in GstreamerSingleStreamTest::GstreamerSingleStreamTest()()<br>
<br>
<br>
________________________________________________________________________________________________________<br>
*** CID 356328:  Uninitialized members  (UNINIT_CTOR)<br>
/home/kbingham/iob/libcamera/ci/libcamera-ci/src/libcamera/test/gstreamer/gstreamer_single_stream_test.cpp:<br>
28 in GstreamerSingleStreamTest::GstreamerSingleStreamTest()()<br>
22     class GstreamerSingleStreamTest : public GstreamerTest, public Test<br>
23     {<br>
24     public:<br>
25      GstreamerSingleStreamTest()<br>
26              : GstreamerTest()<br>
27      {<br>
>>>     CID 356328:  Uninitialized members  (UNINIT_CTOR)<br>
>>>     Non-static class member "sink0_" is not initialized in this constructor nor in any functions that it calls.<br>
28      }<br>
29     30     protected:<br>
31      int init() override<br>
32      {<br>
33              if (status_ != TestPass)<br>
<br>
<br>
________________________________________________________________________________________________________<br>
To view the defects in Coverity Scan visit,<br>
<a href="https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrU0jHZztxHSfchEdEv-2BUERKUFDFlzchxJzxDB2S7OB7lr-2Fth-2F9ZTRF1ITl33bQQto-3DRAq-_qXXIY1fr7HINeQlTFVXABgVX8iKf8Pc2W6xJCOtsiCw64f2YdDCRdgu4-2FkWCuqEXXWChBofooTa0y8KFKOtgnQjde4dBU-2FZgvswyAI5XO0ekKbl9nJU6QKX8C2y6l1P7xdneHu7FTOGRCCAOgFpo9CzI1NUv0wR5mDIWD0v-2BUaNkvZl7QKJqhKIko14Culzsq4C22fUP2mTGLY6ahhRTdrC-2F-2BpJjGS7x-2F0NNU9aMIj8-3D" rel="noreferrer" target="_blank">https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrU0jHZztxHSfchEdEv-2BUERKUFDFlzchxJzxDB2S7OB7lr-2Fth-2F9ZTRF1ITl33bQQto-3DRAq-_qXXIY1fr7HINeQlTFVXABgVX8iKf8Pc2W6xJCOtsiCw64f2YdDCRdgu4-2FkWCuqEXXWChBofooTa0y8KFKOtgnQjde4dBU-2FZgvswyAI5XO0ekKbl9nJU6QKX8C2y6l1P7xdneHu7FTOGRCCAOgFpo9CzI1NUv0wR5mDIWD0v-2BUaNkvZl7QKJqhKIko14Culzsq4C22fUP2mTGLY6ahhRTdrC-2F-2BpJjGS7x-2F0NNU9aMIj8-3D</a><br>
<br>
</blockquote></div>