<div dir="ltr">Hi again Lee<div><br></div><div>Thanks for the information. I've PMed you my shipping details and phone number. If you're happy for me to do so I will then take the samples, run them through the tuning tool and submit a more complete colour tuning.</div><div><br></div><div>Best regards</div><div>David</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 11 Oct 2021 at 13:12, Arducam info <<a href="mailto:info@arducam.com">info@arducam.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><div>Hi David and Naush</div><div>As you know Arducam keeps working for camera solutions for Raspberry pi for a long time.</div><div>This new IMX519 camera is the latest open source camera driver and ISP tuned libcamera json config.</div><div>We have already committed the IMX519 driver source code to RaspberryPi/linux repo with Dave Stevenson weeks ago: <a href="https://github.com/raspberrypi/linux/pull/4548/commits" target="_blank">https://github.com/raspberrypi/linux/pull/4548/commits</a> </div><div><br></div><div>And this IMX519 also supports the long exposure as the IMX477, check the statement below from the datasheet.</div><img id="gmail-m_-82044109165361739464006B747-19FF-4B7F-A80B-842F269099D0" width="860" height="105" src="cid:17c6f6d4f9f5b206ef61"><br><div>Please let me know your shipping address and contact phone number, I will send you the first few samples tomorrow with DHL shipping.</div><div>Regards</div><div>Lee</div><div><br></div><div><br></div><div><br><blockquote type="cite"><div>On 11 Oct 2021, at 4:16 PM, David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>> wrote:</div><br><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">Hi Lee</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">Thank you very much for your contribution, we're very pleased to see</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">others making use of the Pi's camera system in this way!</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">On Mon, 11 Oct 2021 at 05:06, Arducam info <</span><a href="mailto:info@arducam.com" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">info@arducam.com</a><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">> wrote:</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br>The necessary tuning file and CamHelper is added for the imx519 sensor.<br><br>The imx519 is a 16MP rolling shutter sensor. To enable<br>it, please add<br><br>dtoverlay=imx519<br><br>to the /boot/config.txt file and reboot the Pi.<br><br>Signed-off-by: Lee Jackson <<a href="mailto:info@arducam.com" target="_blank">info@arducam.com</a>><br>---<br>src/ipa/raspberrypi/cam_helper_imx519.cpp | 185 +++++++++++++++<br>src/ipa/raspberrypi/data/imx519.json      | 272 ++++++++++++++++++++++<br>src/ipa/raspberrypi/data/meson.build      |   1 +<br>src/ipa/raspberrypi/meson.build           |   1 +<br>4 files changed, 459 insertions(+)<br>create mode 100644 src/ipa/raspberrypi/cam_helper_imx519.cpp<br>create mode 100644 src/ipa/raspberrypi/data/imx519.json<br><br>diff --git a/src/ipa/raspberrypi/cam_helper_imx519.cpp b/src/ipa/raspberrypi/cam_helper_imx519.cpp<br>new file mode 100644<br>index 00000000..eaf24982<br>--- /dev/null<br>+++ b/src/ipa/raspberrypi/cam_helper_imx519.cpp<br>@@ -0,0 +1,185 @@<br>+/* SPDX-License-Identifier: BSD-2-Clause */<br>+/*<br>+ * Based on cam_helper_imx477.cpp<br>+ * Copyright (C) 2020, Raspberry Pi (Trading) Limited<br>+ *<br>+ * cam_helper_imx519.cpp - camera helper for imx519 sensor<br>+ * Copyright (C) 2021, Arducam Technology co., Ltd.<br>+ */<br>+<br>+#include <assert.h><br>+#include <cmath><br>+#include <stddef.h><br>+#include <stdio.h><br>+#include <stdlib.h><br>+<br>+#include <libcamera/base/log.h><br>+<br>+#include "cam_helper.hpp"<br>+#include "md_parser.hpp"<br>+<br>+using namespace RPiController;<br>+using namespace libcamera;<br>+using libcamera::utils::Duration;<br>+<br>+namespace libcamera {<br>+LOG_DECLARE_CATEGORY(IPARPI)<br>+}<br>+<br>+/*<br>+ * We care about two gain registers and a pair of exposure registers. Their<br>+ * I2C addresses from the Sony IMX519 datasheet:<br>+ */<br>+constexpr uint32_t expHiReg = 0x0202;<br>+constexpr uint32_t expLoReg = 0x0203;<br>+constexpr uint32_t gainHiReg = 0x0204;<br>+constexpr uint32_t gainLoReg = 0x0205;<br>+constexpr uint32_t frameLengthHiReg = 0x0340;<br>+constexpr uint32_t frameLengthLoReg = 0x0341;<br>+constexpr std::initializer_list<uint32_t> registerList =<br>+       { expHiReg, expLoReg, gainHiReg, gainLoReg, frameLengthHiReg, frameLengthLoReg  };<br>+<br>+class CamHelperImx519 : public CamHelper<br>+{<br>+public:<br>+       CamHelperImx519();<br>+       uint32_t GainCode(double gain) const override;<br>+       double Gain(uint32_t gain_code) const override;<br>+       void Prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata) override;<br>+       uint32_t GetVBlanking(Duration &exposure, Duration minFrameDuration,<br>+                             Duration maxFrameDuration) const override;<br>+       void GetDelays(int &exposure_delay, int &gain_delay,<br>+                      int &vblank_delay) const override;<br>+       bool SensorEmbeddedDataPresent() const override;<br>+<br>+private:<br>+       /*<br>+        * Smallest difference between the frame length and integration time,<br>+        * in units of lines.<br>+        */<br>+       static constexpr int frameIntegrationDiff = 32;<br>+       /* Maximum frame length allowable for long exposure calculations. */<br>+       static constexpr int frameLengthMax = 0xffdc;<br>+       /* Largest long exposure scale factor given as a left shift on the frame length. */<br>+       static constexpr int longExposureShiftMax = 7;<br>+<br>+       void PopulateMetadata(const MdParser::RegisterMap &registers,<br>+                             Metadata &metadata) const override;<br>+};<br>+<br>+CamHelperImx519::CamHelperImx519()<br>+       : CamHelper(std::make_unique<MdParserSmia>(registerList), frameIntegrationDiff)<br>+{<br>+}<br>+<br>+uint32_t CamHelperImx519::GainCode(double gain) const<br>+{<br>+       return static_cast<uint32_t>(1024 - 1024 / gain);<br>+}<br>+<br>+double CamHelperImx519::Gain(uint32_t gain_code) const<br>+{<br>+       return 1024.0 / (1024 - gain_code);<br>+}<br>+<br>+void CamHelperImx519::Prepare(libcamera::Span<const uint8_t> buffer, Metadata &metadata)<br>+{<br>+       MdParser::RegisterMap registers;<br>+       DeviceStatus deviceStatus;<br>+<br>+       if (metadata.Get("device.status", deviceStatus)) {<br>+               LOG(IPARPI, Error) << "DeviceStatus not found from DelayedControls";<br>+               return;<br>+       }<br>+<br>+       parseEmbeddedData(buffer, metadata);<br>+<br>+       /*<br>+        * The DeviceStatus struct is first populated with values obtained from<br>+        * DelayedControls. If this reports frame length is > frameLengthMax,<br>+        * it means we are using a long exposure mode. Since the long exposure<br>+        * scale factor is not returned back through embedded data, we must rely<br>+        * on the existing exposure lines and frame length values returned by<br>+        * DelayedControls.<br>+        *<br>+        * Otherwise, all values are updated with what is reported in the<br>+        * embedded data.<br>+        */<br>+       if (deviceStatus.frame_length > frameLengthMax) {<br>+               DeviceStatus parsedDeviceStatus;<br>+<br>+               metadata.Get("device.status", parsedDeviceStatus);<br>+               parsedDeviceStatus.shutter_speed = deviceStatus.shutter_speed;<br>+               parsedDeviceStatus.frame_length = deviceStatus.frame_length;<br>+               metadata.Set("device.status", parsedDeviceStatus);<br>+<br>+               LOG(IPARPI, Debug) << "Metadata updated for long exposure: "<br>+                                  << parsedDeviceStatus;<br>+       }<br>+}<br>+<br>+uint32_t CamHelperImx519::GetVBlanking(Duration &exposure,<br>+                                      Duration minFrameDuration,<br>+                                      Duration maxFrameDuration) const<br>+{<br>+       uint32_t frameLength, exposureLines;<br>+       unsigned int shift = 0;<br>+<br>+       frameLength = mode_.height + CamHelper::GetVBlanking(exposure, minFrameDuration,<br>+                                                            maxFrameDuration);<br>+       /*<br>+        * Check if the frame length calculated needs to be setup for long<br>+        * exposure mode. This will require us to use a long exposure scale<br>+        * factor provided by a shift operation in the sensor.<br>+        */<br>+       while (frameLength > frameLengthMax) {<br>+               if (++shift > longExposureShiftMax) {<br>+                       shift = longExposureShiftMax;<br>+                       frameLength = frameLengthMax;<br>+                       break;<br>+               }<br>+               frameLength >>= 1;<br>+       }<br>+<br>+       if (shift) {<br>+               /* Account for any rounding in the scaled frame length value. */<br>+               frameLength <<= shift;<br>+               exposureLines = ExposureLines(exposure);<br>+               exposureLines = std::min(exposureLines, frameLength - frameIntegrationDiff);<br>+               exposure = Exposure(exposureLines);<br>+       }<br>+<br>+       return frameLength - mode_.height;<br>+}<br>+<br>+void CamHelperImx519::GetDelays(int &exposure_delay, int &gain_delay,<br>+                               int &vblank_delay) const<br>+{<br>+       exposure_delay = 2;<br>+       gain_delay = 2;<br>+       vblank_delay = 3;<br>+}<br>+<br>+bool CamHelperImx519::SensorEmbeddedDataPresent() const<br>+{<br>+       return true;<br>+}<br>+<br>+void CamHelperImx519::PopulateMetadata(const MdParser::RegisterMap &registers,<br>+                                      Metadata &metadata) const<br>+{<br>+       DeviceStatus deviceStatus;<br>+<br>+       deviceStatus.shutter_speed = Exposure(<a href="http://registers.at" target="_blank">registers.at</a>(expHiReg) * 256 + <a href="http://registers.at" target="_blank">registers.at</a>(expLoReg));<br>+       deviceStatus.analogue_gain = Gain(<a href="http://registers.at" target="_blank">registers.at</a>(gainHiReg) * 256 + <a href="http://registers.at" target="_blank">registers.at</a>(gainLoReg));<br>+       deviceStatus.frame_length = <a href="http://registers.at" target="_blank">registers.at</a>(frameLengthHiReg) * 256 + <a href="http://registers.at" target="_blank">registers.at</a>(frameLengthLoReg);<br>+<br>+       metadata.Set("device.status", deviceStatus);<br>+}<br>+<br>+static CamHelper *Create()<br>+{<br>+       return new CamHelperImx519();<br>+}<br>+<br>+static RegisterCamHelper reg("imx519", &Create);<br>diff --git a/src/ipa/raspberrypi/data/imx519.json b/src/ipa/raspberrypi/data/imx519.json<br>new file mode 100644<br>index 00000000..39e788ad<br>--- /dev/null<br>+++ b/src/ipa/raspberrypi/data/imx519.json<br>@@ -0,0 +1,272 @@<br>+{<br>+    "rpi.black_level":<br>+    {<br>+        "black_level": 4096<br>+    },<br>+    "rpi.dpc":<br>+    {<br>+    },<br>+    "rpi.lux":<br>+    {<br>+        "reference_shutter_speed": 10812,<br>+        "reference_gain": 2.0,<br>+        "reference_aperture": 1.0,<br>+        "reference_lux": 1250,<br>+        "reference_Y": 12737<br>+    },<br>+    "rpi.noise":<br>+    {<br>+        "reference_constant": 0,<br>+        "reference_slope": 2.91<br>+    },<br>+    "rpi.geq":<br>+    {<br>+        "offset": 444,<br>+        "slope": 0.00731<br>+    },<br>+    "rpi.sdn":<br>+    {<br>+        "deviation":3.7,<br>+        "strength":0.75<br>+    },<br>+    "rpi.awb":<br>+    {<br>+        "priors":<br>+        [<br>+            {<br>+                "lux": 0, "prior":<br>+                [<br>+                    2000, 1.0, 3000, 0.0, 13000, 0.0<br>+                ]<br>+            },<br>+            {<br>+                "lux": 800, "prior":<br>+                [<br>+                    2000, 0.0, 6000, 2.0, 13000, 2.0<br>+                ]<br>+            },<br>+            {<br>+                "lux": 1500, "prior":<br>+                [<br>+                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000, 1.0, 13000, 1.0<br>+                ]<br>+            }<br>+        ],<br>+        "modes":<br>+        {<br>+            "auto":<br>+            {<br>+                "lo": 2500,<br>+                "hi": 8000<br>+            },<br>+            "incandescent":<br>+            {<br>+                "lo": 2500,<br>+                "hi": 3000<br>+            },<br>+            "tungsten":<br>+            {<br>+                "lo": 3000,<br>+                "hi": 3500<br>+            },<br>+            "fluorescent":<br>+            {<br>+                "lo": 4000,<br>+                "hi": 4700<br>+            },<br>+            "indoor":<br>+            {<br>+                "lo": 3000,<br>+                "hi": 5000<br>+            },<br>+            "daylight":<br>+            {<br>+                "lo": 5500,<br>+                "hi": 6500<br>+            },<br>+            "cloudy":<br>+            {<br>+                "lo": 7000,<br>+                "hi": 8600<br>+            }<br>+        },<br>+        "bayes": 0<br></blockquote><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">Just a small thing, but if we're going with the simple grey world</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">algorithm it might be worth deleting the other AWB parameters as they</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">don't do anything.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">And a few final questions:</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">* Are you planning to upstream an open source driver for the imx519?</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">The preference within libcamera (someone will correct me if I'm</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">wrong!) is to support sensors where code and drivers are open.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">* If you're planning to open-source the driver we'd be pleased to</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">receive pull requests into our own Raspberry Pi kernel distribution.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">* I assume this is a fairly standard Bayer sensor? If you have a</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">working open source driver and can send me a module then I'd be very</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">happy to help you further with the json tuning file.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">Thanks and best regards</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline">David</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">+<br>+    },<br>+    "rpi.agc":<br>+    {<br>+        "metering_modes":<br>+        {<br>+            "centre-weighted":<br>+            {<br>+                "weights":<br>+                [<br>+                    3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0<br>+                ]<br>+            },<br>+            "spot":<br>+            {<br>+                "weights":<br>+                [<br>+                    2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0<br>+                ]<br>+            },<br>+            "matrix":<br>+            {<br>+                "weights":<br>+                [<br>+                    1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1<br>+                ]<br>+            }<br>+        },<br>+        "exposure_modes":<br>+        {<br>+            "normal":<br>+            {<br>+                "shutter":<br>+                [<br>+                    100, 10000, 30000, 60000, 120000<br>+                ],<br>+                "gain":<br>+                [<br>+                    1.0, 2.0, 4.0, 6.0, 12.0<br>+                ]<br>+            },<br>+            "short":<br>+            {<br>+                "shutter":<br>+                [<br>+                    100, 5000, 10000, 20000, 120000<br>+                ],<br>+                "gain":<br>+                [<br>+                    1.0, 2.0, 4.0, 6.0, 12.0<br>+                ]<br>+            }<br>+        },<br>+        "constraint_modes":<br>+        {<br>+            "normal":<br>+            [<br>+                {<br>+                    "bound": "LOWER", "q_lo": 0.98, "q_hi": 1.0, "y_target":<br>+                    [<br>+                        0, 0.5, 1000, 0.5<br>+                    ]<br>+                }<br>+            ],<br>+            "highlight":<br>+            [<br>+                {<br>+                    "bound": "LOWER", "q_lo": 0.98, "q_hi": 1.0, "y_target":<br>+                    [<br>+                        0, 0.5, 1000, 0.5<br>+                    ]<br>+                },<br>+                {<br>+                    "bound": "UPPER", "q_lo": 0.98, "q_hi": 1.0, "y_target":<br>+                    [<br>+                        0, 0.8, 1000, 0.8<br>+                    ]<br>+                }<br>+            ]<br>+        },<br>+        "y_target":<br>+        [<br>+            0, 0.16, 1000, 0.165, 10000, 0.17<br>+        ]<br>+    },<br>+    "rpi.alsc":<br>+    {<br>+        "omega": 1.3,<br>+        "n_iter": 100,<br>+        "luminance_strength": 0.5,<br>+        "calibrations_Cr":<br>+        [<br>+            {<br>+                "ct": 6500, "table":<br>+                [<br>+                    2.544, 2.541, 2.531, 2.518, 2.506, 2.495, 2.489, 2.489, 2.489, 2.491, 2.502, 2.511, 2.524, 2.534, 2.542, 2.547,<br>+                    2.541, 2.532, 2.521, 2.506, 2.493, 2.479, 2.469, 2.462, 2.462, 2.473, 2.488, 2.502, 2.511, 2.527, 2.536, 2.542,<br>+                    2.531, 2.523, 2.506, 2.492, 2.474, 2.458, 2.444, 2.435, 2.435, 2.446, 2.466, 2.481, 2.498, 2.511, 2.526, 2.536,<br>+                    2.523, 2.513, 2.492, 2.474, 2.458, 2.438, 2.418, 2.408, 2.408, 2.421, 2.443, 2.463, 2.481, 2.498, 2.517, 2.526,<br>+                    2.513, 2.502, 2.481, 2.459, 2.438, 2.418, 2.397, 2.379, 2.379, 2.399, 2.421, 2.443, 2.463, 2.486, 2.506, 2.517,<br>+                    2.506, 2.492, 2.469, 2.445, 2.423, 2.397, 2.377, 2.368, 2.369, 2.379, 2.399, 2.427, 2.451, 2.474, 2.495, 2.511,<br>+                    2.506, 2.492, 2.469, 2.445, 2.423, 2.397, 2.372, 2.364, 2.364, 2.374, 2.399, 2.427, 2.449, 2.474, 2.495, 2.511,<br>+                    2.506, 2.493, 2.474, 2.451, 2.426, 2.401, 2.382, 2.368, 2.369, 2.382, 2.405, 2.431, 2.449, 2.476, 2.497, 2.509,<br>+                    2.504, 2.493, 2.475, 2.452, 2.431, 2.412, 2.401, 2.382, 2.382, 2.403, 2.416, 2.438, 2.457, 2.477, 2.497, 2.505,<br>+                    2.499, 2.492, 2.474, 2.457, 2.441, 2.431, 2.412, 2.404, 2.404, 2.416, 2.432, 2.447, 2.459, 2.478, 2.495, 2.501,<br>+                    2.499, 2.488, 2.473, 2.463, 2.453, 2.441, 2.431, 2.425, 2.425, 2.432, 2.445, 2.459, 2.466, 2.478, 2.491, 2.495,<br>+                    2.499, 2.481, 2.472, 2.466, 2.458, 2.449, 2.441, 2.439, 2.439, 2.444, 2.454, 2.464, 2.469, 2.477, 2.484, 2.491<br>+                ]<br>+            }<br>+        ],<br>+        "calibrations_Cb":<br>+        [<br>+            {<br>+                "ct": 6500, "table":<br>+                [<br>+                    1.352, 1.352, 1.349, 1.348, 1.347, 1.346, 1.347, 1.349, 1.351, 1.351, 1.352, 1.353, 1.353, 1.355, 1.358, 1.359,<br>+                    1.359, 1.355, 1.352, 1.349, 1.348, 1.348, 1.348, 1.351, 1.352, 1.352, 1.352, 1.354, 1.356, 1.358, 1.361, 1.366,<br>+                    1.364, 1.359, 1.355, 1.352, 1.349, 1.349, 1.351, 1.353, 1.353, 1.353, 1.355, 1.356, 1.358, 1.362, 1.366, 1.371,<br>+                    1.371, 1.365, 1.359, 1.355, 1.352, 1.352, 1.353, 1.357, 1.357, 1.356, 1.356, 1.359, 1.362, 1.366, 1.371, 1.377,<br>+                    1.375, 1.371, 1.365, 1.362, 1.359, 1.359, 1.359, 1.364, 1.364, 1.364, 1.364, 1.365, 1.367, 1.371, 1.377, 1.382,<br>+                    1.379, 1.375, 1.371, 1.367, 1.367, 1.367, 1.369, 1.373, 1.374, 1.374, 1.373, 1.373, 1.374, 1.377, 1.382, 1.386,<br>+                    1.383, 1.378, 1.374, 1.372, 1.372, 1.372, 1.373, 1.375, 1.378, 1.379, 1.379, 1.379, 1.379, 1.381, 1.386, 1.389,<br>+                    1.384, 1.379, 1.376, 1.374, 1.373, 1.373, 1.374, 1.379, 1.379, 1.379, 1.379, 1.379, 1.381, 1.382, 1.386, 1.394,<br>+                    1.386, 1.379, 1.376, 1.375, 1.374, 1.374, 1.374, 1.378, 1.378, 1.378, 1.378, 1.379, 1.381, 1.383, 1.386, 1.394,<br>+                    1.385, 1.379, 1.376, 1.375, 1.374, 1.374, 1.375, 1.378, 1.378, 1.378, 1.378, 1.379, 1.381, 1.383, 1.387, 1.393,<br>+                    1.379, 1.378, 1.375, 1.374, 1.373, 1.374, 1.375, 1.377, 1.378, 1.378, 1.378, 1.379, 1.381, 1.382, 1.386, 1.388,<br>+                    1.379, 1.376, 1.374, 1.372, 1.372, 1.374, 1.375, 1.377, 1.378, 1.378, 1.377, 1.378, 1.379, 1.382, 1.384, 1.387<br>+                ]<br>+            }<br>+        ],<br>+        "luminance_lut":<br>+        [<br>+            3.257, 3.091, 2.639, 2.301, 2.009, 1.795, 1.742, 1.742, 1.742, 1.742, 1.798, 2.011, 2.309, 2.649, 3.109, 3.251,<br>+            3.091, 2.703, 2.311, 2.059, 1.791, 1.631, 1.529, 1.482, 1.482, 1.533, 1.635, 1.791, 2.068, 2.313, 2.719, 3.109,<br>+            2.707, 2.424, 2.059, 1.791, 1.626, 1.429, 1.329, 1.282, 1.282, 1.333, 1.433, 1.629, 1.791, 2.068, 2.438, 2.719,<br>+            2.555, 2.233, 1.889, 1.626, 1.429, 1.321, 1.176, 1.126, 1.126, 1.181, 1.327, 1.433, 1.629, 1.894, 2.241, 2.538,<br>+            2.482, 2.108, 1.775, 1.518, 1.321, 1.176, 1.112, 1.011, 1.012, 1.122, 1.181, 1.327, 1.523, 1.779, 2.113, 2.462,<br>+            2.478, 2.048, 1.719, 1.465, 1.266, 1.112, 1.009, 1.001, 1.007, 1.012, 1.122, 1.274, 1.469, 1.722, 2.051, 2.454,<br>+            2.478, 2.048, 1.719, 1.465, 1.266, 1.112, 1.004, 1.001, 1.001, 1.011, 1.122, 1.274, 1.469, 1.722, 2.051, 2.454,<br>+            2.478, 2.099, 1.768, 1.511, 1.312, 1.163, 1.108, 1.004, 1.008, 1.112, 1.171, 1.321, 1.515, 1.767, 2.097, 2.454,<br>+            2.541, 2.217, 1.877, 1.614, 1.417, 1.312, 1.163, 1.112, 1.112, 1.171, 1.317, 1.421, 1.616, 1.874, 2.214, 2.516,<br>+            2.686, 2.404, 2.046, 1.779, 1.614, 1.417, 1.317, 1.267, 1.267, 1.319, 1.421, 1.614, 1.773, 2.039, 2.399, 2.669,<br>+            3.063, 2.678, 2.292, 2.046, 1.779, 1.622, 1.521, 1.469, 1.469, 1.519, 1.622, 1.773, 2.038, 2.277, 2.669, 3.049,<br>+            3.224, 3.063, 2.616, 2.285, 1.995, 1.781, 1.725, 1.723, 1.723, 1.723, 1.777, 1.984, 2.271, 2.598, 3.049, 3.187<br>+        ],<br>+        "sigma": 0.005,<br>+        "sigma_Cb": 0.005<br>+    },<br>+    "rpi.contrast":<br>+    {<br>+        "ce_enable": 1,<br>+        "gamma_curve":<br>+        [<br>+            0, 0, 1024, 5040, 2048, 9338, 3072, 12356, 4096, 15312, 5120, 18051, 6144, 20790, 7168, 23193,<br>+            8192, 25744, 9216, 27942, 10240, 30035, 11264, 32005, 12288, 33975, 13312, 35815, 14336, 37600, 15360, 39168,<br>+            16384, 40642, 18432, 43379, 20480, 45749, 22528, 47753, 24576, 49621, 26624, 51253, 28672, 52698, 30720, 53796,<br>+            32768, 54876, 36864, 57012, 40960, 58656, 45056, 59954, 49152, 61183, 53248, 62355, 57344, 63419, 61440, 64476,<br>+            65535, 65535<br>+        ]<br>+    },<br>+    "rpi.ccm":<br>+    {<br>+        "ccms":<br>+        [<br>+            {<br>+                "ct": 5500, "ccm":<br>+                [<br>+                    1.40348, -0.45861, 0.05512, -0.24419, 1.25488, -0.01068, -0.08564, -0.31571, 1.40135<br>+                ]<br>+            }<br>+        ]<br>+    },<br>+    "rpi.sharpen":<br>+    {<br>+               "threshold":1.5,<br>+               "strength":0.5,<br>+               "limit":0.2<br>+    }<br>+}<br>diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build<br>index 2def75cb..e84cd099 100644<br>--- a/src/ipa/raspberrypi/data/meson.build<br>+++ b/src/ipa/raspberrypi/data/meson.build<br>@@ -7,6 +7,7 @@ conf_files = files([<br>    'imx378.json',<br>    'imx477.json',<br>    'imx477_noir.json',<br>+    'imx519.json',<br>    'ov5647.json',<br>    'ov5647_noir.json',<br>    'ov9281.json',<br>diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build<br>index 1af31e4a..176055f4 100644<br>--- a/src/ipa/raspberrypi/meson.build<br>+++ b/src/ipa/raspberrypi/meson.build<br>@@ -22,6 +22,7 @@ rpi_ipa_sources = files([<br>    'cam_helper_imx219.cpp',<br>    'cam_helper_imx290.cpp',<br>    'cam_helper_imx477.cpp',<br>+    'cam_helper_imx519.cpp',<br>    'cam_helper_ov9281.cpp',<br>    'controller/controller.cpp',<br>    'controller/histogram.cpp',<br>--<br>2.17.1</blockquote></div></blockquote></div><br></div></blockquote></div>