<div dir="ltr"><div dir="ltr">Hi Laurent,<div><br></div><div>Thank you for your feedback.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 19 Nov 2021 at 12:50, Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Naush,<br>
<br>
Thank you for the patch.<br>
<br>
On Fri, Nov 19, 2021 at 11:09:55AM +0000, Naushir Patuck wrote:<br>
> Remove unused member variables from class PipelineHandlerRPi.<br>
> <br>
> Signed-off-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> ---<br>
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 +----<br>
>  1 file changed, 1 insertion(+), 4 deletions(-)<br>
> <br>
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
> index 8ed2ebcaafe7..d47306bdfec9 100644<br>
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp<br>
> @@ -317,9 +317,6 @@ private:<br>
>       int prepareBuffers(Camera *camera);<br>
>       void freeBuffers(Camera *camera);<br>
>       void mapBuffers(Camera *camera, const RPi::BufferMap &buffers, unsigned int mask);<br>
> -<br>
> -     MediaDevice *unicam_;<br>
> -     MediaDevice *isp_;<br>
<br>
I'd squash this with patch 2/3, as that's where you remove usage of<br>
those two member variables.<br></blockquote><div><br></div><div>Ack, I'll fix this in the next version.</div><div><br></div><div>Naush</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
>  };<br>
>  <br>
>  RPiCameraConfiguration::RPiCameraConfiguration(const RPiCameraData *data)<br>
> @@ -510,7 +507,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()<br>
>  }<br>
>  <br>
>  PipelineHandlerRPi::PipelineHandlerRPi(CameraManager *manager)<br>
> -     : PipelineHandler(manager), unicam_(nullptr), isp_(nullptr)<br>
> +     : PipelineHandler(manager)<br>
>  {<br>
>  }<br>
>  <br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>