<div dir="ltr"><div dir="ltr">Hi Laurent,<div><br></div><div>Thank you for your work.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 19 Dec 2021 at 23:27, Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
<br>
Some sensors (namely the Sony IMX296, whose support will be added<br>
shortly) require different conversion formulas between exposure time and<br>
exposure lines. Make the Exposure() and ExposureLines() functions<br>
virtual to allow this.<br>
<br>
Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br></blockquote><div><br></div><div>Signed-off-by: Naushir Patuck <<a href="mailto:naushir@gmail.com" target="_blank">naush</a>@<a href="http://raspberrypi.com">raspberrypi.com</a>><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naushir@gmail.com" target="_blank">naush</a>@<a href="http://raspberrypi.com">raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 src/ipa/raspberrypi/cam_helper.hpp | 4 ++--<br>
 1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp<br>
index a776153fcb84..300f8f8a2d3b 100644<br>
--- a/src/ipa/raspberrypi/cam_helper.hpp<br>
+++ b/src/ipa/raspberrypi/cam_helper.hpp<br>
@@ -76,8 +76,8 @@ public:<br>
        virtual void Prepare(libcamera::Span<const uint8_t> buffer,<br>
                             Metadata &metadata);<br>
        virtual void Process(StatisticsPtr &stats, Metadata &metadata);<br>
-       uint32_t ExposureLines(libcamera::utils::Duration exposure) const;<br>
-       libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;<br>
+       virtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;<br>
+       virtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;<br>
        virtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,<br>
                                      libcamera::utils::Duration minFrameDuration,<br>
                                      libcamera::utils::Duration maxFrameDuration) const;<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
<br>
</blockquote></div></div>