<div dir="ltr"><div dir="ltr">Hi Kieran,<div><br></div><div>Thanks for the review!</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 10 Jan 2022 at 14:41, Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com">kieran.bingham@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Quoting Naushir Patuck (2022-01-10 10:23:42)<br>
> Switch the "no buffers available" log message from Info to Debug so that it does<br>
> not get output by default.<br>
> <br>
<br>
I can imagine this is causing unnecessary concern with users?<br></blockquote><div><br></div><div>This is exactly the reason for this change :-)</div><div><br></div><div>Naush</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
And I believe it's valid for streams to not have a buffer when queueing<br>
a request in all cases, so I think this is reasonable.<br>
<br>
Reviewed-by: Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a>><br>
<br>
> Signed-off-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> ---<br>
>  src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 4 ++--<br>
>  1 file changed, 2 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp<br>
> index bab80d25ad1a..a4159e20b068 100644<br>
> --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp<br>
> +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp<br>
> @@ -130,8 +130,8 @@ int Stream::queueBuffer(FrameBuffer *buffer)<br>
>          */<br>
>         if (!buffer) {<br>
>                 if (availableBuffers_.empty()) {<br>
> -                       LOG(RPISTREAM, Info) << "No buffers available for "<br>
> -                                               << name_;<br>
> +                       LOG(RPISTREAM, Debug) << "No buffers available for "<br>
> +                                             << name_;<br>
>                         /*<br>
>                          * Note that we need to queue an internal buffer as soon<br>
>                          * as one becomes available.<br>
> -- <br>
> 2.25.1<br>
><br>
</blockquote></div></div>