<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 22 Mar 2022 at 23:45, Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Mar 22, 2022 at 11:36:23PM +0000, Kieran Bingham wrote:<br>
> Quoting Laurent Pinchart (2022-03-22 23:25:05)<br>
> > On Thu, Mar 17, 2022 at 11:28:01AM +0000, Kieran Bingham wrote:<br>
> > > Quoting Laurent Pinchart (2021-12-19 23:27:12)<br>
> > > > From: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> > > > <br>
> > > > Some sensors (namely the Sony IMX296, whose support will be added<br>
> > > > shortly) require different conversion formulas between exposure time and<br>
> > > > exposure lines. Make the Exposure() and ExposureLines() functions<br>
> > > > virtual to allow this.<br>
> > > <br>
> > > Reviewed-by: Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a>><br>
> > <br>
> > Naush, could I get your SoB line for this patch ?<br>
> <br>
> You have it already in<br>
>  <CAEmqJPpcDLYRtbu0-5aYZxhn0rMgDR15PJj=<a href="mailto:i%2BOKr8dss8NtEw@mail.gmail.com" target="_blank">i+OKr8dss8NtEw@mail.gmail.com</a>><br>
<br>
Oops, sorry for the noise.<br></blockquote><div><br></div><div>Just to confirm :)</div><div><br></div><div>Signed-off-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> > > > Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
> > > > ---<br>
> > > >  src/ipa/raspberrypi/cam_helper.hpp | 4 ++--<br>
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)<br>
> > > > <br>
> > > > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp<br>
> > > > index a776153fcb84..300f8f8a2d3b 100644<br>
> > > > --- a/src/ipa/raspberrypi/cam_helper.hpp<br>
> > > > +++ b/src/ipa/raspberrypi/cam_helper.hpp<br>
> > > > @@ -76,8 +76,8 @@ public:<br>
> > > >         virtual void Prepare(libcamera::Span<const uint8_t> buffer,<br>
> > > >                              Metadata &metadata);<br>
> > > >         virtual void Process(StatisticsPtr &stats, Metadata &metadata);<br>
> > > > -       uint32_t ExposureLines(libcamera::utils::Duration exposure) const;<br>
> > > > -       libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;<br>
> > > > +       virtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;<br>
> > > > +       virtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;<br>
> > > >         virtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,<br>
> > > >                                       libcamera::utils::Duration minFrameDuration,<br>
> > > >                                       libcamera::utils::Duration maxFrameDuration) const;<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>