<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for your work.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 28 Mar 2022 at 11:06, David Plowman via libcamera-devel <<a href="mailto:libcamera-devel@lists.libcamera.org">libcamera-devel@lists.libcamera.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Some of the values were listed incorrectly. Specifically:<br>
<br>
ExposureValue: the range is now centred correctly on zero<br>
Brightness: the default value (0.0) is made explicit<br>
Contrast: the default value is corrected to be 1.0<br>
Saturation: the default value is corrected to be 1.0<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
include/libcamera/ipa/raspberrypi.h | 8 ++++----<br>
1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h<br>
index 7f705e49..6a56b008 100644<br>
--- a/include/libcamera/ipa/raspberrypi.h<br>
+++ b/include/libcamera/ipa/raspberrypi.h<br>
@@ -34,13 +34,13 @@ static const ControlInfoMap Controls({<br>
{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },<br>
{ &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeValues) },<br>
{ &controls::AeExposureMode, ControlInfo(controls::AeExposureModeValues) },<br>
- { &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },<br>
+ { &controls::ExposureValue, ControlInfo(-8.0f, 8.0f, 0.0f) },<br>
{ &controls::AwbEnable, ControlInfo(false, true) },<br>
{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },<br>
{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },<br>
- { &controls::Brightness, ControlInfo(-1.0f, 1.0f) },<br>
- { &controls::Contrast, ControlInfo(0.0f, 32.0f) },<br>
- { &controls::Saturation, ControlInfo(0.0f, 32.0f) },<br>
+ { &controls::Brightness, ControlInfo(-1.0f, 1.0f, 0.0f) },<br>
+ { &controls::Contrast, ControlInfo(0.0f, 32.0f, 1.0f) },<br>
+ { &controls::Saturation, ControlInfo(0.0f, 32.0f, 1.0f) },<br>
{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },<br>
{ &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },<br>
{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },<br>
-- <br>
2.30.2<br>
<br>
</blockquote></div></div>