<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for your work.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 22 Sept 2021 at 14:29, David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The modeSensitivity field is a number that describes how sensitive the<br>
selected sensor mode is compared to other readout modes of the same<br>
sensor. For example, a binned mode might have twice the sensitivity of<br>
the full resolution mode, meaning you would get double the signal<br>
level for the same exposure and gains.<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br>
---<br>
include/libcamera/camera.h | 2 ++<br>
src/libcamera/camera.cpp | 16 +++++++++++++++-<br>
2 files changed, 17 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h<br>
index 601ee46e..3314c06b 100644<br>
--- a/include/libcamera/camera.h<br>
+++ b/include/libcamera/camera.h<br>
@@ -66,6 +66,8 @@ public:<br>
<br>
Transform transform;<br>
<br>
+ float modeSensitivity;<br>
+<br>
protected:<br>
CameraConfiguration();<br>
<br>
diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp<br>
index 71809bcd..8d795dff 100644<br>
--- a/src/libcamera/camera.cpp<br>
+++ b/src/libcamera/camera.cpp<br>
@@ -156,7 +156,7 @@ LOG_DECLARE_CATEGORY(Camera)<br>
* \brief Create an empty camera configuration<br>
*/<br>
CameraConfiguration::CameraConfiguration()<br>
- : transform(Transform::Identity), config_({})<br>
+ : transform(Transform::Identity), modeSensitivity(1.0), config_({})<br>
{<br>
}<br>
<br>
@@ -327,6 +327,20 @@ std::size_t CameraConfiguration::size() const<br>
* may adjust this field at its discretion if the selection is not supported.<br>
*/<br>
<br>
+/**<br>
+ * \var CameraConfiguration::modeSensitivity<br>
+ * \brief The relative sensitivity of the chosen sensor mode<br>
+ *<br>
+ * Some sensors have readout modes with different sensitivities. For example,<br>
+ * a binned camera mode might, with the same exposure and gains, produce<br>
+ * twice the signal level of the full resolution readout. This would be<br>
+ * signalled by the binned mode, when it is chosen, indicating a value here<br>
+ * that is twice that of the full resolution mode.<br>
+ *<br>
+ * This value should only be read, and not set, by the user. It will be<br>
+ * valid after the configure method has reteurned successfully.<br></blockquote><div><br></div><div>s/reteurned/returned/</div><div><br></div><div>Aparat from that:</div><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+ */<br>
+<br>
/**<br>
* \var CameraConfiguration::config_<br>
* \brief The vector of stream configurations<br>
-- <br>
2.20.1<br>
<br>
</blockquote></div></div>