<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 25 Jul 2022 at 16:06, Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Naush,<br>
<br>
Thank you for the series.<br>
<br>
On Mon, Jul 25, 2022 at 02:46:24PM +0100, Naushir Patuck via libcamera-devel wrote:<br>
> Hi,<br>
> <br>
> This rather large patch series performs a (largely overdue) code refactoring on<br>
> all our IPA source files to match the libcamera coding style guidelines.<br>
> <br>
> Given the size of the first round of changes (switching to CamelCase), I've split<br>
> a single large patch into multiple smaller patches (1/15 - 10/15). Please note,<br>
> THESE CANNOT BE MERGED AS-IS (hence the DNI tag) as they will cause intermediate<br>
> compile breakages. Once ready for merging, these must be squashed into a single<br>
> large patch. It also means that the entire context of the change will not fully<br>
> be available in patches 1/15 - 10/15. Apologies for that, but this seems the<br>
> most sensible way to help with the review.<br>
<br>
That's totally fine.<br>
<br>
I've noticed the following remainign usages of snake_case:<br>
<br>
md_parser.h<br>
int bits_per_pixel_;<br>
unsigned int num_lines_;<br>
unsigned int line_length_bytes_;<br>
noise_status.h<br>
double noise_constant;<br>
double noise_slope;<br>
awb.h<br>
int frameCount_; /* counts up to startup_frames */<br>
double computeDelta2Sum(double gain_r, double gainB);<br>
agc_status.h<br>
char constraint_mode[32];<br>
denoise_status.h<br>
double noise_constant;<br>
double noise_slope;<br>
black_level_status.h<br>
uint16_t black_level_r; /* out of 16 bits */<br>
uint16_t black_level_g;<br>
uint16_t black_level_b;<br></blockquote><div><br></div><div>Argh.... and I went through this over and over...</div><div><br></div><div>Thanks for spotting those Laurent. I know not to trust my reg-exp'ing skills :-)</div><div><br></div><div>One thing that you have spotted is the missing 'k' prefix in the constant variables.</div><div>To be honest, I am not a fan of that, so I have left them as starting with a </div><div>capital letter.</div><div><br></div><div>Naush</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> Naushir Patuck (15):<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> DNI: ipa: raspberrypi: Code refactoring to match style guidelines<br>
> ipa: raspberrypi: Change to C style code comments<br>
> ipa: raspberrypi: Remove extern "C" declarations<br>
> ipa: raspberrypi: Rename header files from *.hpp to *.h<br>
> raspberrypi: Update Copyright statement in all Raspberry Pi source<br>
> files<br>
> ipa: raspberryip: Remove all exception throw statements<br>
> <br>
> .reuse/dep5 | 2 +-<br>
> include/libcamera/color_space.h | 2 +-<br>
> include/libcamera/internal/bayer_format.h | 2 +-<br>
> include/libcamera/internal/delayed_controls.h | 2 +-<br>
> include/libcamera/internal/v4l2_pixelformat.h | 2 +-<br>
> include/libcamera/transform.h | 2 +-<br>
> include/linux/bcm2835-isp.h | 2 +-<br>
> src/cam/stream_options.cpp | 2 +-<br>
> src/cam/stream_options.h | 2 +-<br>
> src/ipa/libipa/histogram.cpp | 2 +-<br>
> src/ipa/libipa/histogram.h | 2 +-<br>
> src/ipa/raspberrypi/cam_helper.cpp | 94 +-<br>
> src/ipa/raspberrypi/cam_helper.h | 127 ++<br>
> src/ipa/raspberrypi/cam_helper.hpp | 123 --<br>
> src/ipa/raspberrypi/cam_helper_imx219.cpp | 40 +-<br>
> src/ipa/raspberrypi/cam_helper_imx290.cpp | 36 +-<br>
> src/ipa/raspberrypi/cam_helper_imx296.cpp | 28 +-<br>
> src/ipa/raspberrypi/cam_helper_imx477.cpp | 78 +-<br>
> src/ipa/raspberrypi/cam_helper_imx519.cpp | 76 +-<br>
> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 48 +-<br>
> src/ipa/raspberrypi/cam_helper_ov9281.cpp | 32 +-<br>
> .../raspberrypi/controller/agc_algorithm.h | 31 +<br>
> .../raspberrypi/controller/agc_algorithm.hpp | 32 -<br>
> src/ipa/raspberrypi/controller/agc_status.h | 46 +-<br>
> src/ipa/raspberrypi/controller/algorithm.cpp | 26 +-<br>
> src/ipa/raspberrypi/controller/algorithm.h | 64 +<br>
> src/ipa/raspberrypi/controller/algorithm.hpp | 60 -<br>
> src/ipa/raspberrypi/controller/alsc_status.h | 16 +-<br>
> .../raspberrypi/controller/awb_algorithm.h | 23 +<br>
> .../raspberrypi/controller/awb_algorithm.hpp | 23 -<br>
> src/ipa/raspberrypi/controller/awb_status.h | 24 +-<br>
> .../controller/black_level_status.h | 14 +-<br>
> src/ipa/raspberrypi/controller/camera_mode.h | 54 +-<br>
> .../raspberrypi/controller/ccm_algorithm.h | 21 +<br>
> .../raspberrypi/controller/ccm_algorithm.hpp | 21 -<br>
> src/ipa/raspberrypi/controller/ccm_status.h | 12 +-<br>
> .../controller/contrast_algorithm.h | 22 +<br>
> .../controller/contrast_algorithm.hpp | 22 -<br>
> .../raspberrypi/controller/contrast_status.h | 16 +-<br>
> src/ipa/raspberrypi/controller/controller.cpp | 86 +-<br>
> src/ipa/raspberrypi/controller/controller.h | 58 +<br>
> src/ipa/raspberrypi/controller/controller.hpp | 54 -<br>
> ...oise_algorithm.hpp => denoise_algorithm.h} | 12 +-<br>
> .../raspberrypi/controller/denoise_status.h | 12 +-<br>
> .../raspberrypi/controller/device_status.cpp | 20 +-<br>
> .../raspberrypi/controller/device_status.h | 18 +-<br>
> src/ipa/raspberrypi/controller/dpc_status.h | 14 +-<br>
> src/ipa/raspberrypi/controller/focus_status.h | 20 +-<br>
> src/ipa/raspberrypi/controller/geq_status.h | 12 +-<br>
> src/ipa/raspberrypi/controller/histogram.cpp | 46 +-<br>
> src/ipa/raspberrypi/controller/histogram.h | 48 +<br>
> src/ipa/raspberrypi/controller/histogram.hpp | 44 -<br>
> src/ipa/raspberrypi/controller/lux_status.h | 28 +-<br>
> .../controller/{metadata.hpp => metadata.h} | 40 +-<br>
> src/ipa/raspberrypi/controller/noise_status.h | 12 +-<br>
> src/ipa/raspberrypi/controller/pwl.cpp | 174 +--<br>
> src/ipa/raspberrypi/controller/pwl.h | 126 ++<br>
> src/ipa/raspberrypi/controller/pwl.hpp | 112 --<br>
> src/ipa/raspberrypi/controller/rpi/agc.cpp | 1031 +++++++++--------<br>
> src/ipa/raspberrypi/controller/rpi/agc.h | 141 +++<br>
> src/ipa/raspberrypi/controller/rpi/agc.hpp | 139 ---<br>
> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 854 +++++++-------<br>
> src/ipa/raspberrypi/controller/rpi/alsc.h | 110 ++<br>
> src/ipa/raspberrypi/controller/rpi/alsc.hpp | 106 --<br>
> src/ipa/raspberrypi/controller/rpi/awb.cpp | 762 ++++++------<br>
> src/ipa/raspberrypi/controller/rpi/awb.h | 193 +++<br>
> src/ipa/raspberrypi/controller/rpi/awb.hpp | 179 ---<br>
> .../controller/rpi/black_level.cpp | 46 +-<br>
> .../raspberrypi/controller/rpi/black_level.h | 30 +<br>
> .../controller/rpi/black_level.hpp | 30 -<br>
> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 117 +-<br>
> .../controller/rpi/{ccm.hpp => ccm.h} | 24 +-<br>
> .../raspberrypi/controller/rpi/contrast.cpp | 200 ++--<br>
> src/ipa/raspberrypi/controller/rpi/contrast.h | 52 +<br>
> .../raspberrypi/controller/rpi/contrast.hpp | 50 -<br>
> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 34 +-<br>
> src/ipa/raspberrypi/controller/rpi/dpc.h | 32 +<br>
> src/ipa/raspberrypi/controller/rpi/dpc.hpp | 32 -<br>
> src/ipa/raspberrypi/controller/rpi/focus.cpp | 18 +-<br>
> .../controller/rpi/{focus.hpp => focus.h} | 12 +-<br>
> src/ipa/raspberrypi/controller/rpi/geq.cpp | 64 +-<br>
> src/ipa/raspberrypi/controller/rpi/geq.h | 34 +<br>
> src/ipa/raspberrypi/controller/rpi/geq.hpp | 34 -<br>
> src/ipa/raspberrypi/controller/rpi/lux.cpp | 90 +-<br>
> src/ipa/raspberrypi/controller/rpi/lux.h | 45 +<br>
> src/ipa/raspberrypi/controller/rpi/lux.hpp | 43 -<br>
> src/ipa/raspberrypi/controller/rpi/noise.cpp | 60 +-<br>
> src/ipa/raspberrypi/controller/rpi/noise.h | 32 +<br>
> src/ipa/raspberrypi/controller/rpi/noise.hpp | 32 -<br>
> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 46 +-<br>
> src/ipa/raspberrypi/controller/rpi/sdn.h | 32 +<br>
> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 32 -<br>
> .../raspberrypi/controller/rpi/sharpen.cpp | 72 +-<br>
> src/ipa/raspberrypi/controller/rpi/sharpen.h | 34 +<br>
> .../raspberrypi/controller/rpi/sharpen.hpp | 34 -<br>
> .../controller/sharpen_algorithm.h | 21 +<br>
> .../controller/sharpen_algorithm.hpp | 21 -<br>
> .../raspberrypi/controller/sharpen_status.h | 22 +-<br>
> .../{md_parser.hpp => md_parser.h} | 40 +-<br>
> src/ipa/raspberrypi/md_parser_smia.cpp | 100 +-<br>
> src/ipa/raspberrypi/raspberrypi.cpp | 274 ++---<br>
> src/libcamera/bayer_format.cpp | 2 +-<br>
> src/libcamera/color_space.cpp | 2 +-<br>
> src/libcamera/delayed_controls.cpp | 2 +-<br>
> .../pipeline/raspberrypi/dma_heaps.cpp | 2 +-<br>
> .../pipeline/raspberrypi/dma_heaps.h | 2 +-<br>
> .../pipeline/raspberrypi/raspberrypi.cpp | 2 +-<br>
> .../pipeline/raspberrypi/rpi_stream.cpp | 2 +-<br>
> .../pipeline/raspberrypi/rpi_stream.h | 2 +-<br>
> src/libcamera/transform.cpp | 2 +-<br>
> src/libcamera/v4l2_pixelformat.cpp | 2 +-<br>
> src/qcam/dng_writer.cpp | 2 +-<br>
> src/qcam/dng_writer.h | 2 +-<br>
> utils/raspberrypi/ctt/ctt.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_alsc.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_awb.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_ccm.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_geq.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_image_load.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_lux.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_macbeth_locator.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_noise.py | 2 +-<br>
> .../raspberrypi/ctt/ctt_pretty_print_json.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_ransac.py | 2 +-<br>
> utils/raspberrypi/ctt/ctt_tools.py | 2 +-<br>
> 125 files changed, 3817 insertions(+), 3752 deletions(-)<br>
> create mode 100644 src/ipa/raspberrypi/cam_helper.h<br>
> delete mode 100644 src/ipa/raspberrypi/cam_helper.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/agc_algorithm.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/agc_algorithm.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/algorithm.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/algorithm.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/awb_algorithm.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/awb_algorithm.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/ccm_algorithm.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/ccm_algorithm.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/contrast_algorithm.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/contrast_algorithm.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/controller.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/controller.hpp<br>
> rename src/ipa/raspberrypi/controller/{denoise_algorithm.hpp => denoise_algorithm.h} (53%)<br>
> create mode 100644 src/ipa/raspberrypi/controller/histogram.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/histogram.hpp<br>
> rename src/ipa/raspberrypi/controller/{metadata.hpp => metadata.h} (61%)<br>
> create mode 100644 src/ipa/raspberrypi/controller/pwl.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/pwl.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/agc.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/agc.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/alsc.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/alsc.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/awb.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/awb.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/black_level.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/black_level.hpp<br>
> rename src/ipa/raspberrypi/controller/rpi/{ccm.hpp => ccm.h} (68%)<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/contrast.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/contrast.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/dpc.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/dpc.hpp<br>
> rename src/ipa/raspberrypi/controller/rpi/{focus.hpp => focus.h} (59%)<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/geq.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/geq.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/lux.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/lux.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/noise.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/noise.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/sdn.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/sdn.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/rpi/sharpen.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/rpi/sharpen.hpp<br>
> create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.h<br>
> delete mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp<br>
> rename src/ipa/raspberrypi/{md_parser.hpp => md_parser.h} (80%)<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>