<div dir="ltr"><div dir="ltr">Hi Laurent,<div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 22 Jul 2022 at 20:25, Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Naush,<br>
<br>
On Mon, Jul 18, 2022 at 09:15:58AM +0100, Naushir Patuck wrote:<br>
> From: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
> <br>
> The Raspberry Pi IPA module depends on boost only to parse the JSON<br>
> tuning data files. As libcamera depends on libyaml, use the YamlParser<br>
> class to parse those files and drop the dependency on boost.<br>
> <br>
> Signed-off-by: Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>><br>
<br>
I assume you're fine with this patch as you've posted it as part of your<br>
series, but could you give it a review ? :-)<br></blockquote><div><br></div><div>I did have one outstanding query on this about default values.<br><br>If you recall, we discussed having YamlObject::get() not take in a default value<br>and complain loudly if the key is not present, similar to what the Boost parser<br>does now.  This will help avoid possibly hard to debug issues if a critical<br>parameter is missing from the tuning config.  David, what are your thoughts?<br><br>Do you think this is something that we can add easily to this patch?<br></div><div><br></div><div>Regards,</div><div>Naush</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> ---<br>
>  README.rst                                    |  6 --<br>
>  src/ipa/raspberrypi/controller/algorithm.cpp  |  2 +-<br>
>  src/ipa/raspberrypi/controller/algorithm.hpp  |  6 +-<br>
>  src/ipa/raspberrypi/controller/controller.cpp | 27 ++++--<br>
>  src/ipa/raspberrypi/controller/pwl.cpp        | 12 ++-<br>
>  src/ipa/raspberrypi/controller/pwl.hpp        |  5 +-<br>
>  src/ipa/raspberrypi/controller/rpi/agc.cpp    | 94 +++++++++----------<br>
>  src/ipa/raspberrypi/controller/rpi/agc.hpp    | 10 +-<br>
>  src/ipa/raspberrypi/controller/rpi/alsc.cpp   | 94 +++++++++----------<br>
>  src/ipa/raspberrypi/controller/rpi/alsc.hpp   |  2 +-<br>
>  src/ipa/raspberrypi/controller/rpi/awb.cpp    | 89 +++++++++---------<br>
>  src/ipa/raspberrypi/controller/rpi/awb.hpp    |  8 +-<br>
>  .../controller/rpi/black_level.cpp            | 12 +--<br>
>  .../controller/rpi/black_level.hpp            |  2 +-<br>
>  src/ipa/raspberrypi/controller/rpi/ccm.cpp    | 28 +++---<br>
>  src/ipa/raspberrypi/controller/rpi/ccm.hpp    |  4 +-<br>
>  .../raspberrypi/controller/rpi/contrast.cpp   | 18 ++--<br>
>  .../raspberrypi/controller/rpi/contrast.hpp   |  2 +-<br>
>  src/ipa/raspberrypi/controller/rpi/dpc.cpp    |  4 +-<br>
>  src/ipa/raspberrypi/controller/rpi/dpc.hpp    |  2 +-<br>
>  src/ipa/raspberrypi/controller/rpi/geq.cpp    | 10 +-<br>
>  src/ipa/raspberrypi/controller/rpi/geq.hpp    |  2 +-<br>
>  src/ipa/raspberrypi/controller/rpi/lux.cpp    | 12 +--<br>
>  src/ipa/raspberrypi/controller/rpi/lux.hpp    |  2 +-<br>
>  src/ipa/raspberrypi/controller/rpi/noise.cpp  |  6 +-<br>
>  src/ipa/raspberrypi/controller/rpi/noise.hpp  |  2 +-<br>
>  src/ipa/raspberrypi/controller/rpi/sdn.cpp    |  6 +-<br>
>  src/ipa/raspberrypi/controller/rpi/sdn.hpp    |  2 +-<br>
>  .../raspberrypi/controller/rpi/sharpen.cpp    |  8 +-<br>
>  .../raspberrypi/controller/rpi/sharpen.hpp    |  2 +-<br>
>  src/ipa/raspberrypi/meson.build               |  1 -<br>
>  src/ipa/raspberrypi/raspberrypi.cpp           |  1 +<br>
>  32 files changed, 241 insertions(+), 240 deletions(-)<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>