<div dir="ltr">Hi Laurent,<div><br></div><div>Additionally for this series:<br></div><div>Tested-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>><br></div><div><br></div><div>Naush</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 27 Jul 2022 at 03:38, Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
This patches series replaces the boost JSON parser with the YamlParser<br>
implementation based on libyaml for the Raspberry Pi IPA module.<br>
<br>
Compared to v6 (posted by Naush), the main changes are<br>
<br>
- Rebase on top of "[PATCH 00/17] Raspberry Pi IPA code refactor"<br>
- Addition of patch 01/14 that simplifies usage of the YamlObject::get()<br>
function<br>
- Addition of patches 05/14 to 07/14 that prepare for error handling<br>
during tuning data read<br>
- Propagation of errors in 08/14<br>
- Addition of 13/14 and 14/14 (those are optional and could be merged<br>
separately)<br>
<br>
Florian Sylvestre (1):<br>
libcamera: yaml_parser: Add getList() function<br>
<br>
Laurent Pinchart (9):<br>
libcamera: yaml_parser: Replace ok flag to get() with std::optional<br>
test: yaml-parser: Test dictionary items ordering<br>
libcamera: yaml_parser: Preserve order of items in dictionary<br>
ipa: raspberrypi: Replace tabs with spaces in tuning data files<br>
ipa: raspberrypi: Return an error code from Algorithm::read()<br>
ipa: raspberrypi: Propagate errors from AGC metering tuning data read<br>
ipa: raspberrypi: Replace Fatal log by error propagation<br>
ipa: raspberrypi: Use YamlParser to replace dependency on boost<br>
ipa: raspberrypi: agc: Use YamlObject::getList()<br>
<br>
Naushir Patuck (4):<br>
ipa: raspberrypi: Introduce version 2.0 format for the camera tuning<br>
file<br>
utils: raspberrypi: ctt: Output version 2.0 format tuning files<br>
utils: raspberrypi: Add tuning file conversion script<br>
ipa: raspberrypi: Convert existing cameara tuning files to version 2.0<br>
<br>
README.rst | 6 -<br>
include/libcamera/internal/yaml_parser.h | 62 +-<br>
src/ipa/raspberrypi/controller/algorithm.cpp | 3 +-<br>
src/ipa/raspberrypi/controller/algorithm.h | 6 +-<br>
src/ipa/raspberrypi/controller/controller.cpp | 79 +-<br>
src/ipa/raspberrypi/controller/controller.h | 7 +-<br>
src/ipa/raspberrypi/controller/pwl.cpp | 13 +-<br>
src/ipa/raspberrypi/controller/pwl.h | 4 +-<br>
src/ipa/raspberrypi/controller/rpi/agc.cpp | 220 +++--<br>
src/ipa/raspberrypi/controller/rpi/agc.h | 10 +-<br>
src/ipa/raspberrypi/controller/rpi/alsc.cpp | 149 +--<br>
src/ipa/raspberrypi/controller/rpi/alsc.h | 2 +-<br>
src/ipa/raspberrypi/controller/rpi/awb.cpp | 171 ++--<br>
src/ipa/raspberrypi/controller/rpi/awb.h | 8 +-<br>
.../controller/rpi/black_level.cpp | 13 +-<br>
.../raspberrypi/controller/rpi/black_level.h | 2 +-<br>
src/ipa/raspberrypi/controller/rpi/ccm.cpp | 65 +-<br>
src/ipa/raspberrypi/controller/rpi/ccm.h | 4 +-<br>
.../raspberrypi/controller/rpi/contrast.cpp | 28 +-<br>
src/ipa/raspberrypi/controller/rpi/contrast.h | 2 +-<br>
src/ipa/raspberrypi/controller/rpi/dpc.cpp | 12 +-<br>
src/ipa/raspberrypi/controller/rpi/dpc.h | 2 +-<br>
src/ipa/raspberrypi/controller/rpi/geq.cpp | 22 +-<br>
src/ipa/raspberrypi/controller/rpi/geq.h | 2 +-<br>
src/ipa/raspberrypi/controller/rpi/lux.cpp | 31 +-<br>
src/ipa/raspberrypi/controller/rpi/lux.h | 2 +-<br>
src/ipa/raspberrypi/controller/rpi/noise.cpp | 15 +-<br>
src/ipa/raspberrypi/controller/rpi/noise.h | 2 +-<br>
src/ipa/raspberrypi/controller/rpi/sdn.cpp | 7 +-<br>
src/ipa/raspberrypi/controller/rpi/sdn.h | 2 +-<br>
.../raspberrypi/controller/rpi/sharpen.cpp | 9 +-<br>
src/ipa/raspberrypi/controller/rpi/sharpen.h | 2 +-<br>
src/ipa/raspberrypi/data/imx219.json | 824 ++++++++--------<br>
src/ipa/raspberrypi/data/imx219_noir.json | 686 +++++++-------<br>
src/ipa/raspberrypi/data/imx290.json | 326 ++++---<br>
src/ipa/raspberrypi/data/imx296.json | 369 ++++----<br>
src/ipa/raspberrypi/data/imx378.json | 677 ++++++++------<br>
src/ipa/raspberrypi/data/imx477.json | 881 ++++++++++--------<br>
src/ipa/raspberrypi/data/imx477_noir.json | 734 ++++++++-------<br>
src/ipa/raspberrypi/data/imx519.json | 677 ++++++++------<br>
src/ipa/raspberrypi/data/ov5647.json | 824 ++++++++--------<br>
src/ipa/raspberrypi/data/ov5647_noir.json | 686 +++++++-------<br>
src/ipa/raspberrypi/data/ov9281.json | 195 ++--<br>
src/ipa/raspberrypi/data/se327m12.json | 683 ++++++++------<br>
src/ipa/raspberrypi/data/uncalibrated.json | 180 ++--<br>
src/ipa/raspberrypi/meson.build | 1 -<br>
src/ipa/raspberrypi/raspberrypi.cpp | 10 +-<br>
src/libcamera/yaml_parser.cpp | 228 +++--<br>
test/yaml-parser.cpp | 94 +-<br>
utils/raspberrypi/ctt/convert_tuning.py | 46 +<br>
utils/raspberrypi/ctt/ctt.py | 18 +-<br>
.../raspberrypi/ctt/ctt_pretty_print_json.py | 188 ++--<br>
52 files changed, 5246 insertions(+), 4043 deletions(-)<br>
create mode 100755 utils/raspberrypi/ctt/convert_tuning.py<br>
mode change 100644 => 100755 utils/raspberrypi/ctt/ctt_pretty_print_json.py<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
<br>
</blockquote></div>