<div dir="ltr"><div>Hi Umang,</div><div><br></div><div>Thanks for your review!</div><div>I guess there are only the three comments in your third message that need updates, right?<br>Please check if I miss anything.</div><div dir="ltr"></div><div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 27, 2022 at 3:38 PM Umang Jain <<a href="mailto:umang.jain@ideasonboard.com" target="_blank">umang.jain@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Harvey,<br>
<br>
Thank you for the patch,<br>
<br>
On 6/29/22 16:00, Harvey Yang via libcamera-devel wrote:<br>
> From: Harvey Yang <<a href="mailto:chenghaoyang@chromium.org" target="_blank">chenghaoyang@chromium.org</a>><br>
><br>
> With only one camera being started, we can always use imgu0 to process<br>
> frames (for video/preview). In the following patches, we'll use imgu1<br>
> for still capture if needed.<br>
><br>
> Signed-off-by: Harvey Yang <<a href="mailto:chenghaoyang@chromium.org" target="_blank">chenghaoyang@chromium.org</a>><br>
> ---<br>
>  Â src/libcamera/pipeline/ipu3/ipu3.cpp | 86 ++++++++++++++++------------<br>
>  Â 1 file changed, 48 insertions(+), 38 deletions(-)<br>
><br>
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> index c943ee6a..e219f704 100644<br>
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp<br>
> @@ -64,7 +64,8 @@ public:<br>
>  Â  Â  Â void frameStart(uint32_t sequence);<br>
>  Â <br>
>  Â  Â  Â CIO2Device cio2_;<br>
> -  Â  Â ImgUDevice *imgu_;<br>
> +  Â  Â ImgUDevice *imgu0_;<br>
> +  Â  Â ImgUDevice *imgu1_;<br>
>  Â <br>
>  Â  Â  Â Stream outStream_;<br>
>  Â  Â  Â Stream vfStream_;<br>
> @@ -406,7 +407,7 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()<br>
>  Â <br>
>  Â  Â  Â /* Only compute the ImgU configuration if a YUV stream has been requested. */<br>
>  Â  Â  Â if (yuvCount) {<br>
> -  Â  Â  Â  Â  Â  Â pipeConfig_ = data_->imgu_->calculatePipeConfig(&pipe);<br>
> +  Â  Â  Â  Â  Â  Â pipeConfig_ = data_->imgu0_->calculatePipeConfig(&pipe);<br>
>  Â  Â  Â  Â  Â  Â  Â if (pipeConfig_.isNull()) {<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â LOG(IPU3, Error) << "Failed to calculate pipe configuration: "<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  << "unsupported resolutions.";<br>
> @@ -518,7 +519,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)<br>
>  Â  Â  Â Stream *outStream = &data->outStream_;<br>
>  Â  Â  Â Stream *vfStream = &data->vfStream_;<br>
>  Â  Â  Â CIO2Device *cio2 = &data->cio2_;<br>
> -  Â  Â ImgUDevice *imgu = data->imgu_;<br>
>  Â  Â  Â V4L2DeviceFormat outputFormat;<br>
>  Â  Â  Â int ret;<br>
>  Â <br>
> @@ -560,7 +560,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)<br>
<br>
<br>
We need to update the ::configure() comment about multiple camera <br>
streaming (listed as FIXME) , since we will only stream one camera at a <br>
given time now.<br>
<br></blockquote><div><br></div><div>Updated the comment, not sure if I'm doing it right. Please check :)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
>  Â  Â  Â  * stream which is for raw capture, in which case no buffers will<br>
>  Â  Â  Â  * ever be queued to the ImgU.<br>
>  Â  Â  Â  */<br>
> -  Â  Â ret = data->imgu_->enableLinks(true);<br>
> +  Â  Â ret = imgu0_.enableLinks(true);<br>
>  Â  Â  Â if (ret)<br>
>  Â  Â  Â  Â  Â  Â  Â return ret;<br>
>  Â <br>
> @@ -610,7 +610,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)<br>
>  Â  Â  Â if (imguConfig.isNull())<br>
>  Â  Â  Â  Â  Â  Â  Â return 0;<br>
>  Â <br>
> -  Â  Â ret = imgu->configure(imguConfig, &cio2Format);<br>
> +  Â  Â ret = imgu0_.configure(imguConfig, &cio2Format);<br>
>  Â  Â  Â if (ret)<br>
>  Â  Â  Â  Â  Â  Â  Â return ret;<br>
>  Â <br>
> @@ -624,12 +624,12 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)<br>
>  Â <br>
>  Â  Â  Â  Â  Â  Â  Â if (stream == outStream) {<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â mainCfg = &cfg;<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â ret = imgu->configureOutput(cfg, &outputFormat);<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â ret = imgu0_.configureOutput(cfg, &outputFormat);<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â if (ret)<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â return ret;<br>
>  Â  Â  Â  Â  Â  Â  Â } else if (stream == vfStream) {<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â vfCfg = &cfg;<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â ret = imgu->configureViewfinder(cfg, &outputFormat);<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â ret = imgu0_.configureViewfinder(cfg, &outputFormat);<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â if (ret)<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â return ret;<br>
>  Â  Â  Â  Â  Â  Â  Â }<br>
> @@ -641,13 +641,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)<br>
>  Â  Â  Â  * be at least one active stream in the configuration request).<br>
>  Â  Â  Â  */<br>
>  Â  Â  Â if (!vfCfg) {<br>
> -  Â  Â  Â  Â  Â  Â ret = imgu->configureViewfinder(*mainCfg, &outputFormat);<br>
> +  Â  Â  Â  Â  Â  Â ret = imgu0_.configureViewfinder(*mainCfg, &outputFormat);<br>
>  Â  Â  Â  Â  Â  Â  Â if (ret)<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â return ret;<br>
>  Â  Â  Â }<br>
>  Â <br>
>  Â  Â  Â /* Apply the "pipe_mode" control to the ImgU subdevice. */<br>
> -  Â  Â ControlList ctrls(imgu->imgu_->controls());<br>
> +  Â  Â ControlList ctrls(imgu0_.imgu_->controls());<br>
>  Â  Â  Â /*<br>
>  Â  Â  Â  * Set the ImgU pipe mode to 'Video' unconditionally to have statistics<br>
>  Â  Â  Â  * generated.<br>
> @@ -657,7 +657,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)<br>
>  Â  Â  Â  */<br>
>  Â  Â  Â ctrls.set(V4L2_CID_IPU3_PIPE_MODE,<br>
>  Â  Â  Â  Â  Â  Â  Â  Â static_cast<int32_t>(IPU3PipeModeVideo));<br>
> -  Â  Â ret = imgu->imgu_->setControls(&ctrls);<br>
> +  Â  Â ret = imgu0_.imgu_->setControls(&ctrls);<br>
>  Â  Â  Â if (ret) {<br>
>  Â  Â  Â  Â  Â  Â  Â LOG(IPU3, Error) << "Unable to set pipe_mode control";<br>
>  Â  Â  Â  Â  Â  Â  Â return ret;<br>
> @@ -691,9 +691,9 @@ int PipelineHandlerIPU3::exportFrameBuffers(Camera *camera, Stream *stream,<br>
>  Â  Â  Â unsigned int count = stream->configuration().bufferCount;<br>
>  Â <br>
>  Â  Â  Â if (stream == &data->outStream_)<br>
> -  Â  Â  Â  Â  Â  Â return data->imgu_->output_->exportBuffers(count, buffers);<br>
> +  Â  Â  Â  Â  Â  Â return imgu0_.output_->exportBuffers(count, buffers);<br>
>  Â  Â  Â else if (stream == &data->vfStream_)<br>
> -  Â  Â  Â  Â  Â  Â return data->imgu_->viewfinder_->exportBuffers(count, buffers);<br>
> +  Â  Â  Â  Â  Â  Â return imgu0_.viewfinder_->exportBuffers(count, buffers);<br>
>  Â  Â  Â else if (stream == &data->rawStream_)<br>
>  Â  Â  Â  Â  Â  Â  Â return data->cio2_.exportBuffers(count, buffers);<br>
>  Â <br>
> @@ -711,7 +711,6 @@ int PipelineHandlerIPU3::exportFrameBuffers(Camera *camera, Stream *stream,<br>
>  Â int PipelineHandlerIPU3::allocateBuffers(Camera *camera)<br>
>  Â {<br>
>  Â  Â  Â IPU3CameraData *data = cameraData(camera);<br>
> -  Â  Â ImgUDevice *imgu = data->imgu_;<br>
>  Â  Â  Â unsigned int bufferCount;<br>
>  Â  Â  Â int ret;<br>
>  Â <br>
> @@ -721,26 +720,26 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera)<br>
>  Â  Â  Â  Â  Â  Â  Â data->rawStream_.configuration().bufferCount,<br>
>  Â  Â  Â });<br>
>  Â <br>
> -  Â  Â ret = imgu->allocateBuffers(bufferCount);<br>
> +  Â  Â ret = imgu0_.allocateBuffers(bufferCount);<br>
>  Â  Â  Â if (ret < 0)<br>
>  Â  Â  Â  Â  Â  Â  Â return ret;<br>
>  Â <br>
>  Â  Â  Â /* Map buffers to the IPA. */<br>
>  Â  Â  Â unsigned int ipaBufferId = 1;<br>
>  Â <br>
> -  Â  Â for (const std::unique_ptr<FrameBuffer> &buffer : imgu->paramBuffers_) {<br>
> +  Â  Â for (const std::unique_ptr<FrameBuffer> &buffer : imgu0_.paramBuffers_) {<br>
>  Â  Â  Â  Â  Â  Â  Â buffer->setCookie(ipaBufferId++);<br>
>  Â  Â  Â  Â  Â  Â  Â ipaBuffers_.emplace_back(buffer->cookie(), buffer->planes());<br>
>  Â  Â  Â }<br>
>  Â <br>
> -  Â  Â for (const std::unique_ptr<FrameBuffer> &buffer : imgu->statBuffers_) {<br>
> +  Â  Â for (const std::unique_ptr<FrameBuffer> &buffer : imgu0_.statBuffers_) {<br>
>  Â  Â  Â  Â  Â  Â  Â buffer->setCookie(ipaBufferId++);<br>
>  Â  Â  Â  Â  Â  Â  Â ipaBuffers_.emplace_back(buffer->cookie(), buffer->planes());<br>
>  Â  Â  Â }<br>
>  Â <br>
>  Â  Â  Â data->ipa_->mapBuffers(ipaBuffers_);<br>
>  Â <br>
> -  Â  Â data->frameInfos_.init(imgu->paramBuffers_, imgu->statBuffers_);<br>
> +  Â  Â data->frameInfos_.init(imgu0_.paramBuffers_, imgu0_.statBuffers_);<br>
>  Â  Â  Â data->frameInfos_.bufferAvailable.connect(<br>
>  Â  Â  Â  Â  Â  Â  Â data, &IPU3CameraData::queuePendingRequests);<br>
>  Â <br>
> @@ -760,7 +759,7 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera)<br>
>  Â  Â  Â data->ipa_->unmapBuffers(ids);<br>
>  Â  Â  Â ipaBuffers_.clear();<br>
>  Â <br>
> -  Â  Â data->imgu_->freeBuffers();<br>
> +  Â  Â imgu0_.freeBuffers();<br>
>  Â <br>
>  Â  Â  Â return 0;<br>
>  Â }<br>
> @@ -777,9 +776,18 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis<br>
>  Â <br>
>  Â  Â  Â IPU3CameraData *data = cameraData(camera);<br>
>  Â  Â  Â CIO2Device *cio2 = &data->cio2_;<br>
> -  Â  Â ImgUDevice *imgu = data->imgu_;<br>
>  Â  Â  Â int ret;<br>
>  Â <br>
> +  Â  Â imgu0_.input_->bufferReady.connect(&data->cio2_,<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  &CIO2Device::tryReturnBuffer);<br>
> +  Â  Â imgu0_.output_->bufferReady.connect(data,<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &IPU3CameraData::imguOutputBufferReady);<br>
> +  Â  Â imgu0_.viewfinder_->bufferReady.connect(data,<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &IPU3CameraData::imguOutputBufferReady);<br>
> +  Â  Â imgu0_.param_->bufferReady.connect(data,<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  &IPU3CameraData::paramBufferReady);<br>
> +  Â  Â imgu0_.stat_->bufferReady.connect(data,<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &IPU3CameraData::statBufferReady);<br>
>  Â  Â  Â /* Disable test pattern mode on the sensor, if any. */<br>
>  Â  Â  Â ret = cio2->sensor()->setTestPatternMode(<br>
>  Â  Â  Â  Â  Â  Â  Â controls::draft::TestPatternModeEnum::TestPatternModeOff);<br>
> @@ -807,19 +815,24 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis<br>
>  Â  Â  Â if (ret)<br>
>  Â  Â  Â  Â  Â  Â  Â goto error;<br>
>  Â <br>
> -  Â  Â ret = imgu->start();<br>
> +  Â  Â ret = imgu0_.start();<br>
>  Â  Â  Â if (ret)<br>
>  Â  Â  Â  Â  Â  Â  Â goto error;<br>
>  Â <br>
>  Â  Â  Â return 0;<br>
>  Â <br>
>  Â error:<br>
> -  Â  Â imgu->stop();<br>
> +  Â  Â imgu0_.stop();<br>
>  Â  Â  Â cio2->stop();<br>
>  Â  Â  Â data->ipa_->stop();<br>
>  Â  Â  Â freeBuffers(camera);<br>
>  Â  Â  Â LOG(IPU3, Error) << "Failed to start camera " << camera->id();<br>
>  Â <br>
> +  Â  Â imgu0_.input_->bufferReady.disconnect();<br>
> +  Â  Â imgu0_.output_->bufferReady.disconnect();<br>
> +  Â  Â imgu0_.viewfinder_->bufferReady.disconnect();<br>
> +  Â  Â imgu0_.param_->bufferReady.disconnect();<br>
> +  Â  Â imgu0_.stat_->bufferReady.disconnect();<br>
>  Â  Â  Â inUseCamera_ = nullptr;<br>
>  Â <br>
>  Â  Â  Â return ret;<br>
> @@ -834,13 +847,19 @@ void PipelineHandlerIPU3::stopDevice(Camera *camera)<br>
>  Â <br>
>  Â  Â  Â data->ipa_->stop();<br>
>  Â <br>
> -  Â  Â ret |= data->imgu_->stop();<br>
> +  Â  Â ret |= imgu0_.stop();<br>
>  Â  Â  Â ret |= data->cio2_.stop();<br>
>  Â  Â  Â if (ret)<br>
>  Â  Â  Â  Â  Â  Â  Â LOG(IPU3, Warning) << "Failed to stop camera " << camera->id();<br>
>  Â <br>
>  Â  Â  Â freeBuffers(camera);<br>
>  Â <br>
> +  Â  Â data->imgu0_->input_->bufferReady.disconnect();<br>
> +  Â  Â data->imgu0_->output_->bufferReady.disconnect();<br>
> +  Â  Â data->imgu0_->viewfinder_->bufferReady.disconnect();<br>
> +  Â  Â data->imgu0_->param_->bufferReady.disconnect();<br>
> +  Â  Â data->imgu0_->stat_->bufferReady.disconnect();<br>
> +<br>
<br>
<br>
I think we should better abstract the signal connections/disconnections <br>
to IMGU somehow, if we are going to use them in ::start().<br>
<br>
Probably the abstractions can come through IPU3CameraData ?<br>
<br></blockquote><div><br></div><div>For connections, |input_->bufferReady| is bound to CIO2Device instead, and we need to bind different methods on |imgu1_|'s signals, when StillCapture is enabled.</div><div>I don't think there's an elegant way to abstract it...? </div><div><br></div><div>For disconnections, I think adding a helper function in ImgUDevice should be simpler. WDYT? (Added in the next version)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
>  Â  Â  Â inUseCamera_ = nullptr;<br>
>  Â }<br>
>  Â <br>
> @@ -1184,7 +1203,8 @@ int PipelineHandlerIPU3::registerCameras()<br>
>  Â  Â  Â  Â  Â  Â  Â  * only, and assign imgu0 to the first one and imgu1 to the<br>
>  Â  Â  Â  Â  Â  Â  Â  * second.<br>
>  Â  Â  Â  Â  Â  Â  Â  */<br>
> -  Â  Â  Â  Â  Â  Â data->imgu_ = numCameras ? &imgu1_ : &imgu0_;<br>
> +  Â  Â  Â  Â  Â  Â data->imgu0_ = &imgu0_;<br>
> +  Â  Â  Â  Â  Â  Â data->imgu1_ = &imgu1_;<br>
>  Â <br>
>  Â  Â  Â  Â  Â  Â  Â /*<br>
>  Â  Â  Â  Â  Â  Â  Â  * Connect video devices' 'bufferReady' signals to their<br>
> @@ -1198,16 +1218,6 @@ int PipelineHandlerIPU3::registerCameras()<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &IPU3CameraData::cio2BufferReady);<br>
>  Â  Â  Â  Â  Â  Â  Â data->cio2_.bufferAvailable.connect(<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â data.get(), &IPU3CameraData::queuePendingRequests);<br>
<br>
<br>
How about we move the cio2_ signals connection to <br>
PIpelineHandlerIPU3::Start() as well? There are 2 signals w.r.t cio2_ : <br>
bufferReady and bufferAvailable.<br>
<br></blockquote><div> </div><div>Hmm, but PipelineHandlerIPU3::Start() might be called multiple times, while we only need to setup |cio2_|'s signals connection once. Right?</div><div>  </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> -  Â  Â  Â  Â  Â  Â data->imgu_->input_->bufferReady.connect(&data->cio2_,<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &CIO2Device::tryReturnBuffer);<br>
> -  Â  Â  Â  Â  Â  Â data->imgu_->output_->bufferReady.connect(data.get(),<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &IPU3CameraData::imguOutputBufferReady);<br>
> -  Â  Â  Â  Â  Â  Â data->imgu_->viewfinder_->bufferReady.connect(data.get(),<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &IPU3CameraData::imguOutputBufferReady);<br>
> -  Â  Â  Â  Â  Â  Â data->imgu_->param_->bufferReady.connect(data.get(),<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &IPU3CameraData::paramBufferReady);<br>
> -  Â  Â  Â  Â  Â  Â data->imgu_->stat_->bufferReady.connect(data.get(),<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â &IPU3CameraData::statBufferReady);<br>
>  Â <br>
>  Â  Â  Â  Â  Â  Â  Â /* Create and register the Camera instance. */<br>
>  Â  Â  Â  Â  Â  Â  Â const std::string &cameraId = cio2->sensor()->id();<br>
> @@ -1300,14 +1310,14 @@ void IPU3CameraData::paramsBufferReady(unsigned int id)<br>
>  Â  Â  Â  Â  Â  Â  Â FrameBuffer *outbuffer = it.second;<br>
>  Â <br>
>  Â  Â  Â  Â  Â  Â  Â if (stream == &outStream_)<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â imgu_->output_->queueBuffer(outbuffer);<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â imgu0_->output_->queueBuffer(outbuffer);<br>
>  Â  Â  Â  Â  Â  Â  Â else if (stream == &vfStream_)<br>
> -  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â imgu_->viewfinder_->queueBuffer(outbuffer);<br>
> +  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â imgu0_->viewfinder_->queueBuffer(outbuffer);<br>
>  Â  Â  Â }<br>
>  Â <br>
> -  Â  Â imgu_->param_->queueBuffer(info->paramBuffer);<br>
> -  Â  Â imgu_->stat_->queueBuffer(info->statBuffer);<br>
> -  Â  Â imgu_->input_->queueBuffer(info->rawBuffer);<br>
> +  Â  Â imgu0_->param_->queueBuffer(info->paramBuffer);<br>
> +  Â  Â imgu0_->stat_->queueBuffer(info->statBuffer);<br>
> +  Â  Â imgu0_->input_->queueBuffer(info->rawBuffer);<br>
>  Â }<br>
>  Â <br>
>  Â void IPU3CameraData::metadataReady(unsigned int id, const ControlList &metadata)<br>
</blockquote></div></div>