<div dir="ltr"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div dir="ltr"><div style="font-size:12.8px"><div style="font-size:12.8px"><div style="color:rgb(136,136,136);font-size:small"><font face="arial, helvetica, sans-serif" color="#000000">Hey, so now I'm <i>really</i> confused by the post-commit. It almost seems like it wants me to use a mix of spaces and tabs, which I've never seen before. Let me know what you make of this:</font></div><div style="color:rgb(136,136,136);font-size:small"><font face="arial, helvetica, sans-serif" color="#000000"><br></font></div><div style="color:rgb(136,136,136);font-size:small"><font face="arial, helvetica, sans-serif" color="#000000">I start with this suggestion:</font></div><div style="font-size:small"><font color="#888888">-</font><font color="#000000">-- src/ipa/ipu3/algorithms/agc.cpp<br>+++ src/ipa/ipu3/algorithms/agc.cpp<br>@@ -101,7 +101,7 @@<br>        /* Configure the default exposure and gain. */<br>        activeState.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain);<br>        activeState.agc.exposure = 10ms /<br>-                                       std::chrono::duration(configuration.sensor.lineDuration);<br>+                                  std::chrono::duration(configuration.sensor.lineDuration);<br><br>        frameCount_ = 0;<br>        return 0;<br></font></div><div style="font-size:small"><font color="#000000"><br></font></div><div style="font-size:small"><font color="#000000">Then when I delete a tab as suggested, I end up with this:</font></div><div style="font-size:small"><font color="#000000">--- src/ipa/ipu3/algorithms/agc.cpp<br>+++ src/ipa/ipu3/algorithms/agc.cpp<br>@@ -101,7 +101,7 @@<br>        /* Configure the default exposure and gain. */<br>        activeState.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain);<br>        activeState.agc.exposure = 10ms /<br>-                               std::chrono::duration(configuration.sensor.lineDuration);<br>+                                  std::chrono::duration(configuration.sensor.lineDuration);<br><br>        frameCount_ = 0;<br>        return 0;</font><br></div><div style="color:rgb(136,136,136);font-size:small"><br></div></div></div></div></div></div></div>If a mix of tabs and spaces is what's standard for us, I'll do it. I just thought to ask first since it would be the first time I've seen a project with this convention.<div><br></div><div>Thanks,</div><div>-Nicholas</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 27, 2022 at 6:18 AM Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com">kieran.bingham@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Quoting Nicholas Roth (2022-10-27 05:24:28)<br>
> >  cp utils/hooks/post-commit .git/hooks/post-commit<br>
> The post-commits seem to want me to replace my tabs with spaces. I use tabs<br>
> to be consistent with the surrounding codebase. Is it OK to ignore these<br>
> errors, or should I do something else?<br>
<br>
That's odd - it shouldn't be changing tabs for spaces?<br>
<br>
What's your tabsize set to ? We use 8-character tabs.<br>
<br>
<br>
> Example:<br>
> --- src/android/camera_hal_config.cpp<br>
> +++ src/android/camera_hal_config.cpp<br>
> @@ -164,7 +164,7 @@<br>
>         File file(filePath);<br>
>         if (!file.exist()) {<br>
>                 LOG(HALConfig, Debug)<br>
> -                                       << "Configuration file: \"" <<<br>
> filePath << "\" not found";<br>
> +                       << "Configuration file: \"" << filePath << "\" not<br>
> found";<br>
>                 return -ENOENT;<br>
<br>
In my terminal, this change looks correct:<br>
<br>
                LOG(HALConfig, Debug)<br>
                        << "Configuration file: \"" << filePath << "\" not found";<br>
<br>
We often take the debug print lines to the following line to allow a<br>
longer length without breaking the text, or hitting our line length<br>
limit. We only use a single indentation from the start of the previous<br>
line<br>
<br>
--<br>
Kieran<br>
<br>
<br>
>         }<br>
> <br>
> ---<br>
> 1 potential issue detected, please review<br>
</blockquote></div>