<div dir="ltr"><div dir="ltr">Hi Laurent,<div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 14 Nov 2022 at 14:01, Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com" target="_blank">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Naush,<br>
<br>
On Mon, Nov 14, 2022 at 11:31:57AM +0000, Naushir Patuck via libcamera-devel wrote:<br>
> Hi,<br>
> <br>
> All patches now have their review tags in this series. Unless there are no<br>
> other objections, it would be great if this could be merged.<br>
<br>
I still very much dislike the cookie in the delayed controls class. All<br>
other platforms are moving or will move to a frame context queue in the<br>
IPA module.<br>
<br>
If you want to go this way, I'll likely fork the DelayedControls class,<br>
and move your implementation to the RPi pipeline handler. This will<br>
likely mean a long term divergence in behaviour between Raspberry Pi and<br>
other platforms, which I don't think is a good idea.<br></blockquote><div><br></div><div>I don't think we are ready to make the jump to frame context queues just yet,</div><div>there is just way too much code to refactor.</div><div><br></div><div>I'll rework this series to fork DelayedControls in RPi namespace with the cookie</div><div>change, and we can consider what to do longer-term.</div><div><br></div><div>Regards,</div><div>Naush</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> On Tue, 8 Nov 2022 at 09:39, Naushir Patuck wrote:<br>
> <br>
> > Hi all,<br>
> ><br>
> > Any chance we could progress this one please. Patches 3/4/6 need a second<br>
> > review.<br>
> ><br>
> > Many thanks,<br>
> > Naush<br>
> ><br>
> > PS: <a href="http://patchwork.libcamera.org" rel="noreferrer" target="_blank">patchwork.libcamera.org</a> seems to be a bit unhappy for a few days now.<br>
> > Might need a reboot!<br>
> ><br>
> ><br>
> > On Mon, 31 Oct 2022 at 11:45, Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> > wrote:<br>
> ><br>
> >> Hi,<br>
> >><br>
> >> In version 7:<br>
> >><br>
> >> - For patch 2/7, the cookie must be provided in push() and reset(). Updated the<br>
> >> rkisp1 and ipu3 pipeline handlers to provide frame numbers for the cookie value.<br>
> >> - For patch 3/4, add a test for skipped/dropped frames and cookie handling.<br>
> >> - Updated patch 6/7 to use the request sequence number for the context index<br>
> >> instead of using a separte sequence counter.<br>
> >><br>
> >> Thanks,<br>
> >> Naush<br>
> >><br>
> >> Naushir Patuck (7):<br>
> >>Â Â delayed_controls: Template the ControlRingBuffer class<br>
> >>Â Â delayed_controls: Add user cookie to DelayedControls<br>
> >>Â Â tests: delayed_controls: Add cookie tests<br>
> >>Â Â ipa: raspberrypi: Add RPiController::Metadata::mergeCopy<br>
> >>Â Â ipa: raspberrypi: Use an array of RPiController::Metadata objects<br>
> >>Â Â pipeline: ipa: raspberrypi: Use IPA cookies<br>
> >>Â Â ipa: raspberrypi: agc: Fix digital gain calculation for manual mode<br>
> >><br>
> >>Â include/libcamera/internal/delayed_controls.h |Â 21 +--<br>
> >> include/libcamera/ipa/raspberrypi.mojom    |  6 +-<br>
> >> src/ipa/raspberrypi/controller/metadata.h   | 10 ++<br>
> >> src/ipa/raspberrypi/controller/rpi/agc.cpp  | 10 +-<br>
> >> src/ipa/raspberrypi/raspberrypi.cpp      | 104 +++++++++------<br>
> >> src/libcamera/delayed_controls.cpp      | 22 ++--<br>
> >> src/libcamera/pipeline/ipu3/ipu3.cpp     |  9 +-<br>
> >> .../pipeline/raspberrypi/raspberrypi.cpp   | 18 ++-<br>
> >> src/libcamera/pipeline/rkisp1/rkisp1.cpp   |  7 +-<br>
> >> test/delayed_controls.cpp           | 121 ++++++++++++++++--<br>
> >>Â 10 files changed, 240 insertions(+), 88 deletions(-)<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div>
</div>