<div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div>Thank you for your patch.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 8 Dec 2022 at 13:44, David Plowman via libcamera-devel <<a href="mailto:libcamera-devel@lists.libcamera.org">libcamera-devel@lists.libcamera.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The Python bindings will now accept, or return, a list or tuple of<br>
libcamera.Rectangle objects for such controls.<br>
<br>
This had previously been omitted, but now we have, for example, the<br>
AfWindows control which requires this feature.<br>
<br>
Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br></blockquote><div><br></div><div>Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com">naush@raspberrypi.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
---<br>
 src/py/libcamera/py_helpers.cpp | 8 +++-----<br>
 1 file changed, 3 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp<br>
index f685e606..79891ab6 100644<br>
--- a/src/py/libcamera/py_helpers.cpp<br>
+++ b/src/py/libcamera/py_helpers.cpp<br>
@@ -46,10 +46,8 @@ py::object controlValueToPy(const ControlValue &cv)<br>
                return valueOrTuple<float>(cv);<br>
        case ControlTypeString:<br>
                return py::cast(cv.get<std::string>());<br>
-       case ControlTypeRectangle: {<br>
-               const Rectangle *v = reinterpret_cast<const Rectangle *>(cv.data().data());<br>
-               return py::cast(v);<br>
-       }<br>
+       case ControlTypeRectangle:<br>
+               return valueOrTuple<Rectangle>(cv);<br>
        case ControlTypeSize: {<br>
                const Size *v = reinterpret_cast<const Size *>(cv.data().data());<br>
                return py::cast(v);<br>
@@ -88,7 +86,7 @@ ControlValue pyToControlValue(const py::object &ob, ControlType type)<br>
        case ControlTypeString:<br>
                return ControlValue(ob.cast<std::string>());<br>
        case ControlTypeRectangle:<br>
-               return ControlValue(ob.cast<Rectangle>());<br>
+               return controlValueMaybeArray<Rectangle>(ob);<br>
        case ControlTypeSize:<br>
                return ControlValue(ob.cast<Size>());<br>
        case ControlTypeNone:<br>
-- <br>
2.30.2<br>
<br>
</blockquote></div></div>