<div dir="ltr"><div dir="ltr">Hi Laurent,<div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Dec 14, 2022 at 5:13 PM Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Dec 14, 2022 at 11:12:29AM +0200, Laurent Pinchart wrote:<br>
> Hi Harvey,<br>
<br>
Sorry, I still need to wake up :-) The comment about help with<br>
refactoring was for Harvey, but I of course meant Cheng-Hao here.<br>
<br>
> On Wed, Dec 07, 2022 at 01:59:15PM +0800, Cheng-Hao Yang via libcamera-devel wrote:<br>
> > Hi Kieran,<br>
> > <br>
> > I see, while I actually found that the patch leads to a flaky crash in cros<br>
> > camera service. I'm still debugging with Han-lin. After I find the root cause,<br>
> > I'll ask Tomasz to take a look. And I'll also provide the CTS result.<br>
> <br>
> Thank you.<br>
> <br>
> I was wondering if you'd like any help with the review comments I've<br>
> sent, in particular with the proposed refactoring of the libjpeg-based<br>
> encoder.<br>
></blockquote><div><br></div><div>Definitely. Sorry for the belated reply. I wanted to solve the flaky issue altogether</div><div>before sending the new version of patches.</div><div>Sorry for the delay!</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
> > On Thu, Dec 1, 2022 at 6:25 PM Kieran Bingham wrote:<br>
> > > Quoting Harvey Yang via libcamera-devel (2022-12-01 09:27:27)<br>
> > > > Rebased and fixed some merge conflicts on the master branch.<br>
> > > > Please check if it's ready to merge.<br>
> > > > Thanks!<br>
> > ><br>
> > > One of our usual key requirements for merge are at least two reviewers<br>
> > > having reviewed and provided reviewed-by tags (after working through any<br>
> > > identified issues and discussions).<br>
> > ><br>
> > > As this component is greatly affecting the Android layer which is used<br>
> > > extensively by ChromeOS ... could we have one of the required reviewers<br>
> > > and testers being from Google or Chromium teams please?<br>
> > ><br>
> > > Providing a reference to results from running CTS would also be<br>
> > > beneficial here.<br>
> > ><br>
> > > > Harvey Yang (6):<br>
> > > > Allow inheritance of Fra</blockquote>Harvey Yang <<a href="mailto:chenghaoyang@chromium.org">chenghaoyang@chromium.org</a>><br>Thu, Dec 1, 5:27 PM (13 days ago)<br><br>to libcamera-devel, Harvey<br><br>Rebased and fixed some merge conflicts on the master branch.<br>Please check if it's ready to merge.<br>Thanks!<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">meBuffer<br>
> > > > Add HALFrameBuffer and replace FrameBuffer in src/android<br>
> > > > Add meson.build in src/android/jpeg<br>
> > > > Move generateThumbnail from PostProcessorJpeg to Encoder<br>
> > > > Pass StreamBuffer to Encoder::encoder<br>
> > > > Add JEA implementation<br>
> > > ><br>
> > > > include/libcamera/framebuffer.h | 3 +-<br>
> > > > src/android/camera_device.cpp | 3 +-<br>
> > > > src/android/cros/camera3_hal.cpp | 2 +<br>
> > > > src/android/cros_mojo_token.h | 12 ++<br>
> > > > src/android/frame_buffer_allocator.h | 7 +-<br>
> > > > src/android/hal_framebuffer.cpp | 22 +++<br>
> > > > src/android/hal_framebuffer.h | 26 ++++<br>
> > > > src/android/jpeg/encoder.h | 10 +-<br>
> > > > src/android/jpeg/encoder_jea.cpp | 93 ++++++++++++<br>
> > > > src/android/jpeg/encoder_jea.h | 35 +++++<br>
> > > > src/android/jpeg/encoder_libjpeg.cpp | 133 ++++++++++++++----<br>
> > > > src/android/jpeg/encoder_libjpeg.h | 33 ++++-<br>
> > > > src/android/jpeg/meson.build | 16 +++<br>
> > > > src/android/jpeg/post_processor_jpeg.cpp | 65 ++-------<br>
> > > > src/android/jpeg/post_processor_jpeg.h | 11 +-<br>
> > > > src/android/meson.build | 6 +-<br>
> > > > .../mm/cros_frame_buffer_allocator.cpp | 9 +-<br>
> > > > .../mm/generic_frame_buffer_allocator.cpp | 11 +-<br>
> > > > 18 files changed, 385 insertions(+), 112 deletions(-)<br>
> > > > create mode 100644 src/android/cros_mojo_token.h<br>
> > > > create mode 100644 src/android/hal_framebuffer.cpp<br>
> > > > create mode 100644 src/android/hal_framebuffer.h<br>
> > > > create mode 100644 src/android/jpeg/encoder_jea.cpp<br>
> > > > create mode 100644 src/android/jpeg/encoder_jea.h<br>
> > > > create mode 100644 src/android/jpeg/meson.build<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div></div>