<div dir="ltr">commit 4c220580fc2c71a978dc768619b6e65f3a5aea4a (HEAD -> master)<br>Author: Fang Hui <<a href="mailto:hui.fang@nxp.com">hui.fang@nxp.com</a>><br>Date:   Thu Jan 25 02:11:04 2024 +0800<br><br>    android: camera_device: The first valid settings should be saved<br><br>    If not, it will be deferred to the next frame.<br><br>    Signed-off-by: Fang Hui <<a href="mailto:hui.fang@nxp.com">hui.fang@nxp.com</a>><br><br>diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp<br>index 25cedd44..d45ed1a5 100644<br>--- a/src/android/camera_device.cpp<br>+++ b/src/android/camera_device.cpp<br>@@ -952,8 +952,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques<br>         */<br>        if (camera3Request->settings)<br>                lastSettings_ = camera3Request->settings;<br>-       else<br>-               descriptor->settings_ = lastSettings_;<br>+<br>+       descriptor->settings_ = lastSettings_;<br><br>        LOG(HAL, Debug) << "Queueing request " << descriptor->request_->cookie()<br>                        << " with " << descriptor->buffers_.size() << " streams";<br><div><br></div><div><br></div><div>BRs,</div><div>Fang Hui</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Laurent Pinchart <<a href="mailto:laurent.pinchart@ideasonboard.com">laurent.pinchart@ideasonboard.com</a>> 于2024年2月21日周三 21:13写道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Hui,<br>
<br>
Thank you for the patch.<br>
<br>
On Wed, Feb 21, 2024 at 01:38:00PM +0800, hui fang wrote:<br>
> The first valid settings should be saved, or will be deferred to the next frame.<br>
<br>
This is missing a Signed-off-by tag, and the subject is missing a<br>
prefix. Both issues should have been caught by the checkstyle.py<br>
utility part of libcamera.<br>
<br>
Please see <a href="https://libcamera.org/contributing.html#submitting-patches" rel="noreferrer" target="_blank">https://libcamera.org/contributing.html#submitting-patches</a><br>
for more information about Signed-off-by, and<br>
<a href="https://libcamera.org/coding-style.html#tools" rel="noreferrer" target="_blank">https://libcamera.org/coding-style.html#tools</a> for more information about<br>
the coding style and checkstyle.py utility.<br>
<br>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp<br>
> index 25cedd44..d45ed1a5 100644<br>
> --- a/src/android/camera_device.cpp<br>
> +++ b/src/android/camera_device.cpp<br>
> @@ -952,8 +952,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques<br>
>          */<br>
>         if (camera3Request->settings)<br>
>                 lastSettings_ = camera3Request->settings;<br>
> -       else<br>
> -               descriptor->settings_ = lastSettings_;<br>
> +<br>
> +       descriptor->settings_ = lastSettings_;<br>
<br>
-- <br>
Regards,<br>
<br>
Laurent Pinchart<br>
</blockquote></div>