<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi, Jacopo<br>
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Sorry for inconvenience. I just updated patches in the previous email "<span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 16px; color: rgb(36, 36, 36); background-color: rgb(255, 255, 255);">[PATCH]
android: camera_device: The first valid settings should be saved".</span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 16px; color: rgb(36, 36, 36); background-color: rgb(255, 255, 255);">Let's go back to this
one.</span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 16px; color: rgb(36, 36, 36); background-color: rgb(255, 255, 255);"><br>
</span></div>
<div class="elementToProof"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 16px; color: rgb(36, 36, 36); background-color: rgb(255, 255, 255);">Yesterday,
after I refined patch, I still used "git send-email", so miss generated this email. </span></div>
<div class="elementToProof"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 16px; color: rgb(36, 36, 36); background-color: rgb(255, 255, 255); font-weight: 600;"><br>
</span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 16px; color: rgb(36, 36, 36); background-color: rgb(255, 255, 255);">BRs,</span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 16px; color: rgb(36, 36, 36); background-color: rgb(255, 255, 255);">Fang Hui</span></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Jacopo Mondi <jacopo.mondi@ideasonboard.com><br>
<b>Sent:</b> Tuesday, February 27, 2024 3:34 PM<br>
<b>To:</b> Hui Fang <hui.fang@nxp.com><br>
<b>Cc:</b> libcamera-devel@lists.libcamera.org <libcamera-devel@lists.libcamera.org>; biomifang118@gmail.com <biomifang118@gmail.com><br>
<b>Subject:</b> [EXT] Re: [PATCH] android: camera_device: Save capture settings unconditionally</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button<br>
<br>
<br>
Hi,<br>
<br>
On Tue, Feb 27, 2024 at 10:13:20AM +0800, Fang Hui wrote:<br>
> If not, it will be deferred to the next frame,<br>
<br>
I proposed an extended commit message in the previous review. If<br>
ignored on purpose, could you suggest me how it could be improved.<br>
Just this one line is too short and not explicative imo<br>
<br>
> as there's a bug assigned to this issue<br>
> <a href="https://bugs.libcamera.org/show_bug.cgi?id=210">https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.libcamera.org%2Fshow_bug.cgi%3Fid%3D210&data=05%7C02%7Chui.fang%40nxp.com%7C8da8a20b2bf6442989e708dc37668466%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638446160678315587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=m3YWD1Ckrhxw3Rq5sDYmToajjGx3L8fwhyjTvXP2WbQ%3D&reserved=0</a><br>
<br>
What I meant was to add:<br>
<br>
Bug: <a href="https://bugs.libcamera.org/show_bug.cgi?id=210">https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.libcamera.org%2Fshow_bug.cgi%3Fid%3D210&data=05%7C02%7Chui.fang%40nxp.com%7C8da8a20b2bf6442989e708dc37668466%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638446160678322482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=HgKM6IVcRFCm5eHp0SPmJMBhUGQOkW8Foz3YAu8T2ns%3D&reserved=0</a><br>
><br>
> Signed-off-by: Fang Hui <hui.fang@nxp.com><br>
<br>
Before the Signed-off-by tag<br>
<br>
> ---<br>
> src/android/camera_device.cpp | 4 ++--<br>
> 1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp<br>
> index 25cedd44..d45ed1a5 100644<br>
> --- a/src/android/camera_device.cpp<br>
> +++ b/src/android/camera_device.cpp<br>
> @@ -952,8 +952,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques<br>
> */<br>
> if (camera3Request->settings)<br>
> lastSettings_ = camera3Request->settings;<br>
> - else<br>
> - descriptor->settings_ = lastSettings_;<br>
> +<br>
> + descriptor->settings_ = lastSettings_;<br>
<br>
I still think you should re-initialize lastSettings_ as I proposed in<br>
the review of the previous version. Was it left out intentionally<br>
because you think it's not needed ? Could you explain why ?<br>
<br>
As I've said, with your ack, I could have made the changes I proposed<br>
before applying the patch, but as you sent a new version I deduce you<br>
disagree with the proposed changes ?<br>
<br>
><br>
> LOG(HAL, Debug) << "Queueing request " << descriptor->request_->cookie()<br>
> << " with " << descriptor->buffers_.size() << " streams";<br>
> --<br>
> 2.25.1<br>
><br>
</div>
</span></font></div>
</body>
</html>