<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 9 May 2024 at 12:15, Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com">kieran.bingham@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Quoting Naushir Patuck (2024-05-08 09:04:00)<br>
> The following member variable will be used by the derived IPAs in an<br>
> upcoming commit, so make them protected:<br>
> <br>
> lensPresent_<br>
> monoSensor_<br>
> <br>
> Signed-off-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> Signed-off-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
<br>
<br>
Reviewed-by: Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a>><br>
Reviewed-by: Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a>><br>
<br>
;-)<br></blockquote><div><br></div><div>I hope to see these duplicated in the merged commit!</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> ---<br>
>  src/ipa/rpi/common/ipa_base.h | 6 +++---<br>
>  1 file changed, 3 insertions(+), 3 deletions(-)<br>
> <br>
> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h<br>
> index 512d7e8fe778..ebdc4d297abb 100644<br>
> --- a/src/ipa/rpi/common/ipa_base.h<br>
> +++ b/src/ipa/rpi/common/ipa_base.h<br>
> @@ -71,6 +71,9 @@ protected:<br>
>         /* Whether the stitch block (if available) needs to swap buffers. */<br>
>         bool stitchSwapBuffers_;<br>
>  <br>
> +       bool monoSensor_;<br>
> +       bool lensPresent_;<br>
> +<br>
>  private:<br>
>         /* Number of metadata objects available in the context list. */<br>
>         static constexpr unsigned int numMetadataContexts = 16;<br>
> @@ -96,9 +99,6 @@ private:<br>
>  <br>
>         std::map<unsigned int, MappedFrameBuffer> buffers_;<br>
>  <br>
> -       bool lensPresent_;<br>
> -       bool monoSensor_;<br>
> -<br>
>         std::array<RPiController::Metadata, numMetadataContexts> rpiMetadata_;<br>
>  <br>
>         /*<br>
> -- <br>
> 2.34.1<br>
><br>
</blockquote></div></div>