<div dir="ltr">Hi Kieran<div><br></div><div>Yes, of course. Please add</div><div><br></div><div>Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com">david.plowman@raspberrypi.com</a>></div><div><br></div><div>to all the patches.</div><div><br></div><div>Thanks!</div><div>David</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 13 Jun 2024 at 09:29, Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com">kieran.bingham@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Quoting Naushir Patuck (2024-06-13 09:16:44)<br>
> Hi David,<br>
> <br>
> Thanks for submitting this. I have been running with these changes<br>
> for a while now so<br>
> <br>
> Tested-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> <br>
<br>
Thanks,<br>
<br>
David, if you can reply with your Signed-off-by: tag here I can apply it<br>
to both Ben and Naush's patches...<br>
<br>
(I think something like 'git send-email -s' will add this for you on any<br>
that might have been missed I believe)<br>
<br>
<br>
> Naush<br>
> <br>
> On Thu, 6 Jun 2024 at 11:15, David Plowman<br>
> <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>> wrote:<br>
> ><br>
> > Hi everyone<br>
> ><br>
> > These 6 patches are a bunch of updates for the Raspberry Pi Camera<br>
> > Tuning Tool (CTT). Mostly they are adding support for the PiSP<br>
> > platform (Pi 5) and probably don't interest too many people.<br>
> ><br>
> > We could choose to apply all these patches now as they don't affect<br>
> > anything in libcamera itself, nor the ability to produce vc4 (Pi 4 or<br>
> > earlier) camera tunings, and then there would be less to apply<br>
> > later. Otherwise we would wait until all the Pi 5 stuff is in, and<br>
> > then we could add these.<br>
> ><br>
> > I note that they don't pass checkstyle - in fact vast swathes of the<br>
> > tuning tool don't. I think that may be a job to tackle separately.<br>
<br>
Indeed,<br>
- <a href="https://gitlab.freedesktop.org/camera/libcamera/-/jobs/59751612" rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/camera/libcamera/-/jobs/59751612</a><br>
<br>
I'm fine with that.<br>
<br>
Acked-by: Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a>><br>
<br>
> ><br>
> > Thanks!<br>
> > David<br>
> ><br>
> > Ben Benson (2):<br>
> > utils: raspberrypi: ctt: Added CAC support to the CTT<br>
> > utils: raspberrypi: ctt: Changed CTT handling of VC4 and PiSP<br>
> ><br>
> > David Plowman (3):<br>
> > utils: raspberrypi: ctt: Adapt tuning tool for both VC4 and PiSP<br>
> > utils: raspberrypi: ctt: Update tuning tool for HDR<br>
> > utils: raspberrypi: ctt: Add a maximum gain parameter for LSC<br>
> ><br>
> > Naushir Patuck (1):<br>
> > utils: raspberrypi: ctt: Add option to convert between vc4/pisp<br>
> > targets<br>
> ><br>
> > utils/raspberrypi/ctt/alsc_only.py | 18 +-<br>
> > utils/raspberrypi/ctt/cac_only.py | 142 +++<br>
> > utils/raspberrypi/ctt/convert_tuning.py | 98 ++-<br>
> > utils/raspberrypi/ctt/ctt.py | 253 +++---<br>
> > utils/raspberrypi/ctt/ctt_alsc.py | 81 +-<br>
> > utils/raspberrypi/ctt/ctt_awb.py | 11 +-<br>
> > utils/raspberrypi/ctt/ctt_cac.py | 228 +++++<br>
> > utils/raspberrypi/ctt/ctt_ccm.py | 6 +-<br>
> > utils/raspberrypi/ctt/ctt_config_example.json | 5 +-<br>
> > utils/raspberrypi/ctt/ctt_dots_locator.py | 118 +++<br>
> > utils/raspberrypi/ctt/ctt_image_load.py | 1 +<br>
> > utils/raspberrypi/ctt/ctt_pisp.py | 805 ++++++++++++++++++<br>
> > .../raspberrypi/ctt/ctt_pretty_print_json.py | 22 +-<br>
> > utils/raspberrypi/ctt/ctt_tools.py | 3 +-<br>
> > utils/raspberrypi/ctt/ctt_vc4.py | 126 +++<br>
> > 15 files changed, 1704 insertions(+), 213 deletions(-)<br>
> > create mode 100644 utils/raspberrypi/ctt/cac_only.py<br>
> > create mode 100644 utils/raspberrypi/ctt/ctt_cac.py<br>
> > create mode 100644 utils/raspberrypi/ctt/ctt_dots_locator.py<br>
> > create mode 100755 utils/raspberrypi/ctt/ctt_pisp.py<br>
> > create mode 100755 utils/raspberrypi/ctt/ctt_vc4.py<br>
> ><br>
> > --<br>
> > 2.39.2<br>
> ><br>
</blockquote></div>