<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 3, 2024 at 6:40 PM Harvey Yang <<a href="mailto:chenghaoyang@chromium.org">chenghaoyang@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi folks,<br>
<br>
This series of patches adds face detection controls in the control ids,<br>
the corresponding usages, and a c'tor of libcamera::Rectangle to<br>
construct it easiler with face detection results.<br>
<br>
It passed gitlab pipeline checks:<br>
<a href="https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1261374" rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1261374</a></blockquote><div>Sorry, forgot to update the link:</div><div><a href="https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/jobs/63084742">https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/jobs/63084742</a><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
This is one of the series cherry-picked from cros mtkisp7 branch.<br>
<br>
The corresponding CLs in cros are:<br>
<a href="https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741266" rel="noreferrer" target="_blank">https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741266</a><br>
<a href="https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741267" rel="noreferrer" target="_blank">https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741267</a><br>
<a href="https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669229" rel="noreferrer" target="_blank">https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669229</a><br>
<a href="https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669232" rel="noreferrer" target="_blank">https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669232</a><br>
<br>
The usages in pipeline handler mtkisp7 will be added later.<br>
<br>
The checkstyle's suggestion on the second patch is ignored, as it<br>
changes the style of previous code.<br>
<br>
v4:<br>
- Added support of FaceDetectModeFull and FaceDetectFaceIds<br>
- Fixed descriptions of control sizes.<br>
<br>
v3: Applied fixes according to Jacopo's comments.<br>
- Moved the new face detection controls from core to draft.<br>
- Amended new controls' descriptions.<br>
<br>
v2:<br>
- Squashed the fourth CL into the last patch, as it's a fix.<br>
- Fixed CLs based on checkstyle's suggestions.<br>
<br>
<br>
BR,<br>
Harvey<br>
<br>
Harvey Yang (1):<br>
  libcamera: android: Add face detection control support<br>
<br>
Yudhistira Erlandinata (2):<br>
  libcamera: Add rectangle two-point constructor<br>
  libcamera: Add face detection controls<br>
<br>
 include/libcamera/controls.h         |  6 ++<br>
 include/libcamera/geometry.h         |  2 +<br>
 src/android/camera_capabilities.cpp  | 45 +++++++++++++--<br>
 src/android/camera_device.cpp        | 75 +++++++++++++++++++++++-<br>
 src/libcamera/control_ids_draft.yaml | 85 ++++++++++++++++++++++++++++<br>
 src/libcamera/controls.cpp           |  6 ++<br>
 src/libcamera/geometry.cpp           | 14 +++++<br>
 7 files changed, 227 insertions(+), 6 deletions(-)<br>
<br>
-- <br>
2.46.0.469.g59c65b2a67-goog<br>
<br>
</blockquote></div></div>