<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>FTR., using</p>
<pre>gainType_ = AnalogueGainExponential;
gainConstants_.exp = { 1.0, expGainDb(0.3) };
</pre>
<p>as used by several other IMX sensors seems to work fine - I just
don't have the bandwidth to prove it somehow. But if you'd
consider accepting such a helper non the less, I'd be happy to
submit a corresponding patch.<br>
</p>
<div class="moz-cite-prefix">On 06.11.24 13:30, Laurent Pinchart
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20241106123039.GD9369@pendragon.ideasonboard.com">
<pre wrap="" class="moz-quote-pre">Hi Robert,
Thank you for the patch.
On Sat, Oct 19, 2024 at 08:43:40PM +0200, Robert Mader wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">64 at 10 bits. The value was guessed from known values for similar
sensors and testing - on a Google Pixel 3a - suggest it's correct.
Adding this tuning file is partly motivated in order to serve as
example, as it's the first one for the simple IPA.
Signed-off-by: Robert Mader <a class="moz-txt-link-rfc2396E" href="mailto:robert.mader@collabora.com"><robert.mader@collabora.com></a>
---
src/ipa/simple/data/imx355.yaml | 11 +++++++++++
src/ipa/simple/data/meson.build | 1 +
2 files changed, 12 insertions(+)
create mode 100644 src/ipa/simple/data/imx355.yaml
diff --git a/src/ipa/simple/data/imx355.yaml b/src/ipa/simple/data/imx355.yaml
new file mode 100644
index 00000000..f7d01b73
--- /dev/null
+++ b/src/ipa/simple/data/imx355.yaml
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: CC0-1.0
+%YAML 1.1
+---
+version: 1
+algorithms:
+ - BlackLevel:
+ blackLevel: 4096
+ - Awb:
+ - Lut:
+ - Agc:
+...
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
To be absolutely honest, I'm not very keen on adding a tuning file for a
sensor that is not supported in the IPA sensor helpers :-S
We're considering a tool to characterize the gain model of sensors, I
wonder if it could be extended to the black level as well. It would be
nicer if we could capture optical black lines.
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">diff --git a/src/ipa/simple/data/meson.build b/src/ipa/simple/data/meson.build
index 92795ee4..6e690f82 100644
--- a/src/ipa/simple/data/meson.build
+++ b/src/ipa/simple/data/meson.build
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: CC0-1.0
conf_files = files([
+ 'imx355.yaml',
'uncalibrated.yaml',
])
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Robert Mader
Consultant Software Developer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718</pre>
</body>
</html>