<div dir="ltr">Hi Jacopo,<div><br></div><div>ah OK, so not every new version of a patch has to be reviewed entirely again then?</div><div>Thanks for the clarification, I'll take it along with any other remarks that you still have.</div><div><br></div><div>Geoffrey</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Op ma 25 nov 2024 om 10:52 schreef Jacopo Mondi <<a href="mailto:jacopo.mondi@ideasonboard.com">jacopo.mondi@ideasonboard.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Geoffrey<br>
  thanks for the patch<br>
<br>
On Sun, Nov 24, 2024 at 08:29:46PM +0100, Geoffrey Van Landeghem wrote:<br>
> The sensor is largely compatible with the already supported<br>
> Sony IMX290 so we can reuse the same helpers for the analogue<br>
> gain conversion functions.<br>
><br>
> Signed-off-by: Geoffrey Van Landeghem <<a href="mailto:geoffrey.vl@gmail.com" target="_blank">geoffrey.vl@gmail.com</a>><br>
<br>
When you receive a tag on patch series version vX you should carry it<br>
forward in version v(X + 1)<br>
<br>
Feels a bit clunky doing that by hand, I know<br>
<br>
Reviewed-by: Jacopo Mondi <<a href="mailto:jacopo.mondi@ideasonboard.com" target="_blank">jacopo.mondi@ideasonboard.com</a>><br>
<br>
Thanks<br>
  j<br>
<br>
> ---<br>
>  src/ipa/libipa/camera_sensor_helper.cpp           | 5 +++++<br>
>  src/ipa/rpi/cam_helper/cam_helper_imx290.cpp      | 1 +<br>
>  src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++<br>
>  3 files changed, 10 insertions(+)<br>
><br>
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp<br>
> index c6169bdc..f870dc28 100644<br>
> --- a/src/ipa/libipa/camera_sensor_helper.cpp<br>
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp<br>
> @@ -622,6 +622,11 @@ public:<br>
>  };<br>
>  REGISTER_CAMERA_SENSOR_HELPER("imx415", CameraSensorHelperImx415)<br>
><br>
> +class CameraSensorHelperImx462 : public CameraSensorHelperImx290<br>
> +{<br>
> +};<br>
> +REGISTER_CAMERA_SENSOR_HELPER("imx462", CameraSensorHelperImx462)<br>
> +<br>
>  class CameraSensorHelperImx477 : public CameraSensorHelper<br>
>  {<br>
>  public:<br>
> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp<br>
> index e57ab538..0cc24a6d 100644<br>
> --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp<br>
> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp<br>
> @@ -73,3 +73,4 @@ static CamHelper *create()<br>
>  }<br>
><br>
>  static RegisterCamHelper reg("imx290", &create);<br>
> +static RegisterCamHelper reg462("imx462", &create);<br>
> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp<br>
> index 6d4136d0..e2305166 100644<br>
> --- a/src/libcamera/sensor/camera_sensor_properties.cpp<br>
> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp<br>
> @@ -142,6 +142,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen<br>
>                       .unitCellSize = { 1450, 1450 },<br>
>                       .testPatternModes = {},<br>
>               } },<br>
> +             { "imx462", {<br>
> +                     .unitCellSize = { 2900, 2900 },<br>
> +                     .testPatternModes = {},<br>
> +             } },<br>
>               { "imx477", {<br>
>                       .unitCellSize = { 1550, 1550 },<br>
>                       .testPatternModes = {},<br>
> --<br>
> 2.43.0<br>
><br>
</blockquote></div>