<div dir="ltr">Yes, it pops out at runtime. I'm not fussed how we fix it really, I'm fine with this.<div><br></div><div>David</div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Mon, 28 Apr 2025 at 14:49, Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com">kieran.bingham@ideasonboard.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Quoting Kieran Bingham (2025-04-28 14:48:26)<br>
> Quoting Naushir Patuck (2025-04-28 14:20:11)<br>
> > Hi David,<br>
> > <br>
> > Thanks for fixing this.<br>
> > <br>
> > On Mon, 28 Apr 2025 at 14:16, David Plowman<br>
> > <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>> wrote:<br>
> > ><br>
> > > The AeEnable control is now just a wrapper that is converted to<br>
> > > ExposureTimeMode and AnalogueGainMode controls instead. Therefore, it<br>
> > > should simply be ignored when we encounter it, without the need for<br>
> > > any warnings.<br>
> > ><br>
> > > Signed-off-by: David Plowman <<a href="mailto:david.plowman@raspberrypi.com" target="_blank">david.plowman@raspberrypi.com</a>><br>
> > <br>
> > Reviewed-by: Naushir Patuck <<a href="mailto:naush@raspberrypi.com" target="_blank">naush@raspberrypi.com</a>><br>
> > <br>
> <br>
> Reviewed-by: Kieran Bingham <<a href="mailto:kieran.bingham@ideasonboard.com" target="_blank">kieran.bingham@ideasonboard.com</a>><br>
> <br>
> > > ---<br>
> > >  src/ipa/rpi/common/ipa_base.cpp | 11 +++++++++++<br>
> > >  1 file changed, 11 insertions(+)<br>
> > ><br>
> > > diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp<br>
> > > index 4c09a093..80c17588 100644<br>
> > > --- a/src/ipa/rpi/common/ipa_base.cpp<br>
> > > +++ b/src/ipa/rpi/common/ipa_base.cpp<br>
> > > @@ -967,6 +967,17 @@ void IpaBase::applyControls(const ControlList &controls)<br>
> > >                         break;<br>
> > >                 }<br>
> > ><br>
> > > +               case controls::AE_ENABLE: {<br>
> > > +                       /*<br>
> > > +                        * The AeEnable control is now just a wrapper that will already have been<br>
> > > +                        * converted to ExposureTimeMode and AnalogueGainMode equivalents, so there<br>
> > > +                        * would be nothing to do here. Nonetheless, "handle" the control so as to<br>
> > > +                        * avoid warnings from the "default:" clause of the switch statement.<br>
> > > +                        */<br>
> > > +<br>
<br>
Is this encountered at runtime? I wonder if the higher level should<br>
'remove' the control that has been handled from the list ... But I'm not<br>
sure I like the idea of modifying the incoming control list ...<br>
<br>
<br>
<br>
> > > +                       break;<br>
> > > +               }<br>
> > > +<br>
> > >                 case controls::AE_FLICKER_MODE: {<br>
> > >                         RPiController::AgcAlgorithm *agc = dynamic_cast<RPiController::AgcAlgorithm *>(<br>
> > >                                 controller_.getAlgorithm("agc"));<br>
> > > --<br>
> > > 2.39.5<br>
> > ><br>
</blockquote></div>