[libcamera-devel] [PATCH v5 04/14] libcamera: v4l2_device: Propagate releaseBuffers() error

Jacopo Mondi jacopo at jmondi.org
Thu Apr 18 12:47:05 CEST 2019


The error code returned by requestBuffers(0) was not propagated to the
caller. Fix it.

Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
 src/libcamera/v4l2_device.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp
index 4cc4a6d656b1..d394632dad4c 100644
--- a/src/libcamera/v4l2_device.cpp
+++ b/src/libcamera/v4l2_device.cpp
@@ -737,10 +737,9 @@ int V4L2Device::releaseBuffers()
 {
 	LOG(V4L2, Debug) << "Releasing bufferPool";
 
-	requestBuffers(0);
 	bufferPool_ = nullptr;
 
-	return 0;
+	return requestBuffers(0);
 }
 
 /**
-- 
2.21.0



More information about the libcamera-devel mailing list