[libcamera-devel] [PATCH v5 05/14] libcamera: request: Add hasPendingBuffers() method

[Jacopo Mondi]

Add method to verify if a request has pending buffers yet to be
completed.

Reviewed-by: Niklas Söderlund <niklas.soderlund at ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
 include/libcamera/request.h |  2 ++
 src/libcamera/request.cpp   | 12 ++++++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/include/libcamera/request.h b/include/libcamera/request.h
index 0dbd425115e8..0188bcab8383 100644
--- a/include/libcamera/request.h
+++ b/include/libcamera/request.h
@@ -37,6 +37,8 @@ public:
 
 	Status status() const { return status_; }
 
+	bool hasPendingBuffers() const { return !pending_.empty(); }
+
 private:
 	friend class Camera;
 	friend class PipelineHandler;
diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp
index e0e77e972411..e5c25d2c6988 100644
--- a/src/libcamera/request.cpp
+++ b/src/libcamera/request.cpp
@@ -106,6 +106,14 @@ Buffer *Request::findBuffer(Stream *stream) const
  * \return The request completion status
  */
 
+/**
+ * \fn Request::hasPendingBuffers()
+ * \brief Check if a request has buffers yet to be completed
+ *
+ * \return True if the request has buffers pending for completion, false
+ * otherwise
+ */
+
 /**
  * \brief Prepare the resources for the completion handler
  */
@@ -127,7 +135,7 @@ int Request::prepare()
  */
 void Request::complete(Status status)
 {
-	ASSERT(pending_.empty());
+	ASSERT(!hasPendingBuffers());
 	status_ = status;
 }
 
@@ -149,7 +157,7 @@ bool Request::completeBuffer(Buffer *buffer)
 	int ret = pending_.erase(buffer);
 	ASSERT(ret == 1);
 
-	return pending_.empty();
+	return !hasPendingBuffers();
 }
 
 } /* namespace libcamera */
-- 
2.21.0