[libcamera-devel] [PATCH 0/2] libcamera: ipu3: more review fixes

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Jan 26 17:41:11 CET 2019


Hi Jacopo,

Thanks you for the patches.

On Sat, Jan 26, 2019 at 05:28:57PM +0100, Jacopo Mondi wrote:
> Address review comments on the IPU3 pipeline handler CameraData usage.

You may want to expland the commit message of 2/2 to explain why the
reworked version is an improvement. In any way,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> Jacopo Mondi (2):
>   libcamera: ipu3: Add method to retrieve camera data
>   libcamera: ipu3: Re-work camera data registration
> 
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list