[libcamera-devel] [PATCH 0/2] libcamera: ipu3: more review fixes

[Jacopo Mondi]

Hi Laurent,

On Sat, Jan 26, 2019 at 06:41:11PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thanks you for the patches.
>
> On Sat, Jan 26, 2019 at 05:28:57PM +0100, Jacopo Mondi wrote:
> > Address review comments on the IPU3 pipeline handler CameraData usage.
>
> You may want to expland the commit message of 2/2 to explain why the
> reworked version is an improvement. In any way,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Thanks, comment expanded and pushed

Thanks
  j

>
> > Jacopo Mondi (2):
> >   libcamera: ipu3: Add method to retrieve camera data
> >   libcamera: ipu3: Re-work camera data registration
> >
> >  src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++------
> >  1 file changed, 10 insertions(+), 6 deletions(-)
> >
>
> --
> Regards,
>
> Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20190129/4f9af63d/attachment.sig>