[libcamera-devel] [PATCH] libcamera: v4l2_device: Fix operator= definition

Jacopo Mondi jacopo at jmondi.org
Sun Jan 27 15:41:52 CET 2019


While the C++ allows the redefinition of operator= to return an
arbitrary type, it is customary to return a reference to the assigned
value type.

Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
---
 src/libcamera/include/v4l2_device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h
index 413bb7f..c67ebbf 100644
--- a/src/libcamera/include/v4l2_device.h
+++ b/src/libcamera/include/v4l2_device.h
@@ -62,7 +62,7 @@ public:
 	V4L2Device(const V4L2Device &) = delete;
 	~V4L2Device();

-	void operator=(const V4L2Device &) = delete;
+	V4L2Device &operator=(const V4L2Device &) = delete;

 	int open();
 	bool isOpen() const;
--
2.20.1



More information about the libcamera-devel mailing list