[libcamera-devel] [PATCH] libcamera: v4l2_device: Fix operator= definition

Jacopo Mondi jacopo at jmondi.org
Sun Jan 27 15:44:46 CET 2019


On Sun, Jan 27, 2019 at 03:41:52PM +0100, Jacopo Mondi wrote:
> While the C++ allows the redefinition of operator= to return an

C++ "standard"

Will eventually fix when pushing.

> arbitrary type, it is customary to return a reference to the assigned
> value type.
>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> ---
>  src/libcamera/include/v4l2_device.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h
> index 413bb7f..c67ebbf 100644
> --- a/src/libcamera/include/v4l2_device.h
> +++ b/src/libcamera/include/v4l2_device.h
> @@ -62,7 +62,7 @@ public:
>  	V4L2Device(const V4L2Device &) = delete;
>  	~V4L2Device();
>
> -	void operator=(const V4L2Device &) = delete;
> +	V4L2Device &operator=(const V4L2Device &) = delete;
>
>  	int open();
>  	bool isOpen() const;
> --
> 2.20.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20190127/a59ba41d/attachment.sig>


More information about the libcamera-devel mailing list