[libcamera-devel] [PATCH 00/10] libcamera: Fixes found while working on new buffer API

[Jacopo Mondi]

Hi Niklas,

On Mon, Oct 28, 2019 at 03:22:14AM +0100, Niklas Söderlund wrote:
> Hi,
>
> This series is a random collection of small fixes I encountered while
> working on the new buffer API. They could hopefully be merged without
> much controversy opposed to the real buffer API change.

The two small comments I had apart, for the whole series:
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks, nice cleanup

>
> Niklas Söderlund (10):
>   libcamera: buffer: Drop forward declaration of BufferPool
>   libcamera: buffer: Plane: Drop friend statement
>   libcamera: buffer: Drop friend statment
>   libcamera: camera: Remove explicit stream to buffer map in
>     requestCompleted signal
>   cam: BufferWriter: Use the libcamera namespace
>   libcamera: v4l2_videodevice: Simplify error checking for
>     requestBuffers()
>   libcamera: pipeline_handler: Do not use argument as local variable
>   libcamera: pipelines: Align where to call base class queueRequest()
>   cam: Store camera as shared pointer everywhere
>   libcamera: pipeline: Drop forward declaration of BufferPool
>
>  include/libcamera/buffer.h               |  4 ---
>  include/libcamera/camera.h               |  2 +-
>  src/cam/buffer_writer.cpp                |  8 +++---
>  src/cam/capture.cpp                      |  6 +++--
>  src/cam/capture.h                        |  7 +++---
>  src/cam/main.cpp                         |  2 +-
>  src/libcamera/camera.cpp                 |  2 +-
>  src/libcamera/include/pipeline_handler.h |  1 -
>  src/libcamera/pipeline/ipu3/ipu3.cpp     |  5 ++--
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp |  4 +--
>  src/libcamera/pipeline/uvcvideo.cpp      |  4 +--
>  src/libcamera/pipeline/vimc.cpp          |  4 +--
>  src/libcamera/pipeline_handler.cpp       |  8 +++---
>  src/libcamera/v4l2_videodevice.cpp       | 31 ++++++++----------------
>  src/qcam/main_window.cpp                 |  5 ++--
>  src/qcam/main_window.h                   |  3 +--
>  test/camera/capture.cpp                  |  4 ++-
>  17 files changed, 42 insertions(+), 58 deletions(-)
>
> --
> 2.23.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel at lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20191106/912626c8/attachment.sig>